Merge pull request #9 from vojtech-dobes/check-exceptions

Check exceptions with PHPStan

Author: vojtech-dobes

composer.json

@@ -35,6 +35,7 @@
 	"require-dev": {
 		"nette/tester": "^2.5.4",
 		"phpstan/phpstan": "^2.1.12",
+		"phpstan/phpstan-strict-rules": "^2.0.4",
 		"spaze/phpstan-disallowed-calls": "^4.5.0",
 		"tracy/tracy": "^2.10.9"
 	},

composer.lock

@@ -24,6 +24,12 @@ parameters:
 			count: 1
 			path: src/GrammarProcessing/LexicalGrammar.php
 
+		-
+			message: '#^Only numeric types are allowed in \-, int\|false given on the right side\.$#'
+			identifier: minus.rightNonNumeric
+			count: 1
+			path: src/GrammarProcessing/LocationGetter.php
+
 		-
 			message: '#^Parameter \$column of class Vojtechdobes\\GrammarProcessing\\Location constructor expects int\<0, max\>, int given\.$#'
 			identifier: argument.type

phpstan-baseline.neon

@@ -1,14 +1,24 @@
 includes:
   - phpstan-baseline.neon
+  - vendor/phpstan/phpstan-strict-rules/rules.neon
   - vendor/spaze/phpstan-disallowed-calls/extension.neon
 
 parameters:
+  checkMissingCallableSignature: true
   disallowedFunctionCalls:
     - function:
         - 'dump()'
         - 'var_dump()'
       message: 'avoid committing debug calls'
 
+  exceptions:
+    check:
+      missingCheckedExceptionInThrows: true
+      tooWideThrowType: true
+
+    uncheckedExceptionClasses:
+      - LogicException
+
   level: 8
   paths:
     - src

phpstan.neon

@@ -37,6 +37,10 @@ public function __construct(
 
 
 
+	/**
+	 * @throws GrammarProcessing\CannotConsumeTokenException
+	 * @throws GrammarProcessing\UnexpectedTokenException
+	 */
 	public function parseGrammarFromSource(string $source): GrammarProcessing\Grammar
 	{
 		return $this->parseGrammarFromAbstractSyntaxTree(

src/GrammarProcessing/Ebnf/Parser.php

@@ -43,6 +43,9 @@ public function __construct(
 
 
 
+	/**
+	 * @throws UnexpectedTokenException
+	 */
 	public function tokenizeSource(string $source): TokenStream
 	{
 		return $this->lexicalGrammar->parseSource($source);
@@ -55,6 +58,7 @@ public function tokenizeSource(string $source): TokenStream
 	 * @param TRootSymbol $rootSymbol
 	 * @return AbstractSyntaxTree<TRootSymbol>
 	 * @throws CannotConsumeTokenException
+	 * @throws UnexpectedTokenException
 	 */
 	public function parseSource(string $source, string $rootSymbol): AbstractSyntaxTree
 	{

src/GrammarProcessing/Grammar.php

@@ -102,6 +102,9 @@ public function consumeTokenWithType(string $type): Token
 
 
 
+	/**
+	 * @throws CannotConsumeTokenException
+	 */
 	public function consumeTokenWithValue(string $value): Token
 	{
 		if (isset($this->tokens[$this->currentToken]) === FALSE) {

src/GrammarProcessing/TokenStream.php

@@ -17,6 +17,7 @@ function getPattern(array $nonterminals): string;
 
 	/**
 	 * @param array<string, Symbol> $nonterminals
+	 * @throws GrammarProcessing\CannotConsumeTokenException
 	 */
 	function acceptNode(
 		GrammarProcessing\Error $error,