Skip to content

Commit 932acf8

Browse files
authored
ci: run tests on windows (#116)
1 parent 4a0c753 commit 932acf8

File tree

2 files changed

+20
-16
lines changed

2 files changed

+20
-16
lines changed

.github/workflows/test.yml

Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ jobs:
88
runs-on: ${{ matrix.os }}
99
strategy:
1010
matrix:
11-
os: [ubuntu-latest, macos-latest]
11+
os: [ubuntu-latest, macos-latest, windows-latest]
1212

1313
steps:
1414
- name: checkout
@@ -21,13 +21,14 @@ jobs:
2121
- name: test
2222
env:
2323
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed for GitHub badge storer integration test
24-
run: go test -timeout=60s -race -count=1 -failfast -shuffle=on ./... -coverprofile=./cover.${{ matrix.os }}.profile -covermode=atomic -coverpkg=./...
24+
run: go test -race -count=1 -failfast -shuffle=on -coverprofile=${{ matrix.os }}-profile -covermode=atomic -coverpkg=./... ./...
2525

2626
- name: upload cover profile artifact
27-
uses: actions/upload-artifact@v3
27+
uses: actions/upload-artifact@v4
2828
with:
29-
name: cover.${{ matrix.os }}
30-
path: cover.${{ matrix.os }}.profile
29+
name: ${{ matrix.os }}-profile
30+
path: ${{ matrix.os }}-profile
31+
if-no-files-found: error
3132

3233
check-coverage:
3334
runs-on: ubuntu-latest
@@ -37,23 +38,26 @@ jobs:
3738
- name: checkout
3839
uses: actions/checkout@v4
3940

40-
- name: download cover.ubuntu-latest
41-
uses: actions/download-artifact@v3
41+
- name: download ubuntu-latest-profile
42+
uses: actions/download-artifact@v4
4243
with:
43-
name: cover.ubuntu-latest
44-
45-
- name: download cover.macos-latest
46-
uses: actions/download-artifact@v3
44+
name: ubuntu-latest-profile
45+
- name: download macos-latest-profile
46+
uses: actions/download-artifact@v4
4747
with:
48-
name: cover.macos-latest
49-
48+
name: macos-latest-profile
49+
- name: download windows-latest-profile
50+
uses: actions/download-artifact@v4
51+
with:
52+
name: windows-latest-profile
53+
5054
- name: check test coverage
5155
id: coverage
5256
uses: vladopajic/go-test-coverage@v2
5357
continue-on-error: true # Should fail after coverage comment is posted
5458
with:
5559
config: ./.github/.testcoverage.yml
56-
profile: cover.ubuntu-latest.profile,cover.macos-latest.profile
60+
profile: ubuntu-latest-profile,macos-latest-profile,windows-latest-profile
5761
git-branch: badges
5862
git-token: ${{ github.ref_name == 'main' && secrets.GITHUB_TOKEN || '' }}
5963

pkg/testcoverage/path/path.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,13 @@ func NormalizeForOS(path string) string {
1313
return path
1414
}
1515

16-
return strings.ReplaceAll(path, "/", separatorToReplace) // coverage-ignore
16+
return strings.ReplaceAll(path, "/", separatorToReplace)
1717
}
1818

1919
func NormalizeForTool(path string) string {
2020
if runtime.GOOS != "windows" {
2121
return path
2222
}
2323

24-
return strings.ReplaceAll(path, separatorToReplace, "/") // coverage-ignore
24+
return strings.ReplaceAll(path, separatorToReplace, "/")
2525
}

0 commit comments

Comments
 (0)