unit tests fixed

Author: vkkis93

build.js

@@ -35,8 +35,8 @@ module.exports = {
         return Promise.resolve()
             .then(() => this.process(this.states[this.stateDefinition.StartAt], this.stateDefinition.StartAt, this.eventFile))
             .catch(err => {
-                console.log('OOPS', err.stack);
-                this.cliLog(err);
+                // console.log('OOPS', err.stack);
+                // this.cliLog(err);
                 throw err;
             });
     },

index.js

@@ -74,7 +74,7 @@ class StepFunctionsOfflinePlugin {
         if (this.options.location) {
             this.location = path.join(process.cwd(), this.options.location);
         }
-        if (this.variables.location) {
+        if (this.variables && this.variables.location) {
             this.location = path.join(process.cwd(), this.variables.location);
         }
     }
@@ -116,6 +116,7 @@ class StepFunctionsOfflinePlugin {
         this.environment = this.serverless.service.provider.environment;
         process.env.STEP_IS_OFFLINE = true;
         process.env = _.extend(process.env, this.environment);
+        return;
     }
 
     findState() {

package.json

@@ -13,7 +13,7 @@
     "url": "git@github.com:vkkis93/serverless-step-functions-offline.git"
   },
   "scripts": {
-    "test": "nyc ./node_modules/mocha/bin/mocha  ./tests/index.test.js './tests/!(index.test).js'",
+    "test": "nyc ./node_modules/mocha/bin/mocha  ./tests/index.test.js ./tests/enum.test.js ./tests/parse.test.js ./tests/build.test.js",
     "lint": "eslint ./**  --ext .js"
   },
   "dependencies": {

parse.js

@@ -1,7 +1,6 @@
 'use strict';
-const BbPromise = require('bluebird');
+const Promise = require('bluebird');
 const path = require('path');
-const _ = require('lodash');
 
 module.exports = {
     yamlParse() {
@@ -37,67 +36,16 @@ module.exports = {
                 }
 
                 this.serverless.variables.populateService(this.serverless.pluginManager.cliOptions);
-                return BbPromise.resolve();
+                return Promise.resolve();
             });
     },
 
-    getAllStateMachines() {
-        if (Object.prototype.toString.call(this.serverless.service.stepFunctions.stateMachines)
-            !== '[object Object]') {
-            const errorMessage = [
-                'stateMachines property is not an object',
-                ' Please check the README for more info.',
-            ].join('');
-            throw new this.serverless.classes
-                .Error(errorMessage);
-        }
-        return Object.keys(this.serverless.service.stepFunctions.stateMachines);
-    },
-
     getStateMachine(stateMachineName) {
         if (stateMachineName in this.serverless.service.stepFunctions.stateMachines) {
             return this.serverless.service.stepFunctions.stateMachines[stateMachineName];
         }
         throw new this.serverless.classes
             .Error(`stateMachine "${stateMachineName}" doesn't exist in this Service`);
-    },
-
-    isStateMachines() {
-        if (this.serverless.service.stepFunctions != null
-            && this.serverless.service.stepFunctions.stateMachines != null
-            && !_.isEmpty(this.serverless.service.stepFunctions.stateMachines)) {
-            return true;
-        }
-        return false;
-    },
-
-    getAllActivities() {
-        if (!Array.isArray(this.serverless.service.stepFunctions.activities)) {
-            const errorMessage = [
-                'activities property is not an array',
-                ' Please check the README for more info.',
-            ].join('');
-            throw new this.serverless.classes
-                .Error(errorMessage);
-        }
-        return this.serverless.service.stepFunctions.activities;
-    },
-
-    getActivity(activityName) {
-        if (this.serverless.service.stepFunctions.activities.indexOf(activityName) !== -1) {
-            return activityName;
-        }
-
-        throw new this.serverless.classes
-            .Error(`activity "${activityName}" doesn't exist in this Service`);
-    },
-
-    isActivities() {
-        if (this.serverless.service.stepFunctions != null
-            && this.serverless.service.stepFunctions.activities != null
-            && !_.isEmpty(this.serverless.service.stepFunctions.activities)) {
-            return true;
-        }
-        return false;
     }
+
 };

tests/build.test.js

@@ -21,7 +21,7 @@ describe('build.js', () => {
                 }).finally(done);
         });
 
-        it('should throw err - can not read property', (done) => {
+        it('should throw err - goody', (done) => {
             stepFunctionsOfflinePlugin.variables = {FirstLambda: 'firstLambda'};
             stepFunctionsOfflinePlugin.hooks[hooks.buildStepWorkFlow]()
                 .then((res) => {

tests/index.test.js

@@ -8,19 +8,20 @@ const StepFunctionsOfflinePlugin = require('../index');
 
 describe('index.js', () => {
     global.hooks = {
-        beforeStart: 'before:step-functions-offline:start',
         start: 'step-functions-offline:start',
         isInstalledPluginSLSStepFunctions: 'step-functions-offline:isInstalledPluginSLSStepFunctions',
         findState: 'step-functions-offline:findState',
         findFunctionsPathAndHandler: 'step-functions-offline:findFunctionsPathAndHandler',
         loadEventFile: 'step-functions-offline:loadEventFile',
+        loadEnvVariables: 'step-functions-offline:loadEnvVariables',
         buildStepWorkFlow: 'step-functions-offline:buildStepWorkFlow'
     };
 
     const options = {
         stateMachine: 'foo',
         s: 'foo',
-        event: null
+        event: null,
+        location: './tests'
     };
     const serverless = new Serverless();
     serverless.cli = new CLI();
@@ -49,14 +50,14 @@ describe('index.js', () => {
 
     describe('#checkVariableInYML', () => {
         it('should throw error - custom.stepFunctionsOffline does not exist', () => {
-            expect(stepFunctionsOfflinePlugin.hooks[hooks.beforeStart]).to.throw(/ENV_VARIABLES/);
+            expect(stepFunctionsOfflinePlugin.hooks[hooks.start]).to.throw(/ENV_VARIABLES/);
         });
 
         it('should exists custom.stepFunctionsOffline', () => {
             stepFunctionsOfflinePlugin.serverless.service.custom = {
                 stepFunctionsOffline: {FirstLambda: 'firstLamda/index.handler'}
             };
-            expect(stepFunctionsOfflinePlugin.hooks[hooks.beforeStart]).to.not.throw();
+            expect(stepFunctionsOfflinePlugin.hooks[hooks.start]).to.not.throw();
         });
 
     });
@@ -113,6 +114,15 @@ describe('index.js', () => {
         });
     })
 
+
+    describe('#loadEnvVariables', () => {
+        it('should return empty object', () => {
+            const result = stepFunctionsOfflinePlugin.hooks[hooks.loadEnvVariables]();
+            expect(result).to.be.undefined;
+        });
+
+    });
+
     describe('#findState', () => {
         it('should throw err - serverless.yml not exists', () => {
             // stepFunctionsOfflinePlugin.serverless.config = process.cwd() + '/serverless.test.yml';

tests/serverless.yml

@@ -33,7 +33,7 @@ stepFunctions:
         States:
             FirstLambda:
               Type: Task
-              Next: wait_using_seconds
+              Next: FinalState
             wait_using_seconds:
               Type: Wait
               Seconds: 10