Combine() - move to separate file

Author: space-alien

CSharpFunctionalExtensions/Result/Methods/Combine.cs

@@ -0,0 +1,59 @@
+using System.Collections.Generic;
+using System.Diagnostics;
+using System.Linq;
+
+namespace CSharpFunctionalExtensions
+{
+    public partial struct Result
+    {
+        [DebuggerStepThrough]
+        public static Result Combine(IEnumerable<Result> results, string errorMessagesSeparator = null)
+        {
+            List<Result> failedResults = results.Where(x => x.IsFailure).ToList();
+
+            if (failedResults.Count == 0)
+                return Ok();
+
+            string errorMessage = string.Join(errorMessagesSeparator ?? ErrorMessagesSeparator, failedResults.Select(x => x.Error));
+            return Fail(errorMessage);
+        }
+
+        [DebuggerStepThrough]
+        public static Result Combine<T>(IEnumerable<Result<T>> results, string errorMessagesSeparator = null)
+        {
+            var untyped = results.Select(result => (Result)result);
+            return Combine(untyped, errorMessagesSeparator);
+        }
+
+        /// <summary>
+        /// Combines several results (and any error messages) into a single result.
+        /// The returned result will be a failure if any of the input <paramref name="results"/> are failures.
+        /// Error messages are concatenated with the default <see cref="Result.ErrorMessagesSeparator" /> between each message.
+        /// </summary>
+        /// <param name="results">The Results to be combined.</param>
+        /// <returns>A Result that is a success when all the input <paramref name="results"/> are also successes.</returns>
+        [DebuggerStepThrough]
+        public static Result Combine(params Result[] results)
+            => Combine(results, ErrorMessagesSeparator);
+
+        /// <summary>
+        /// Combines several results (and any error messages) into a single result.
+        /// The returned result will be a failure if any of the input <paramref name="results"/> are failures.
+        /// Error messages are concatenated with the specified <paramref name="errorMessagesSeparator"/> between each message.
+        /// </summary>
+        /// <param name="errorMessagesSeparator">The string to use as a separator. If omitted, the default <see cref="Result.ErrorMessagesSeparator" /> is used instead.</param>
+        /// <param name="results">The Results to be combined.</param>
+        /// <returns>A Result that is a success when all the input <paramref name="results"/> are also successes.</returns>
+        [DebuggerStepThrough]
+        public static Result Combine(string errorMessagesSeparator, params Result[] results)
+            => Combine(results, errorMessagesSeparator);
+
+        [DebuggerStepThrough]
+        public static Result Combine<T>(params Result<T>[] results)
+            => Combine(results, ErrorMessagesSeparator);
+
+        [DebuggerStepThrough]
+        public static Result Combine<T>(string errorMessagesSeparator, params Result<T>[] results)
+            => Combine(results, errorMessagesSeparator);
+    }
+}

CSharpFunctionalExtensions/Result/Result.cs

@@ -1,15 +1,13 @@
 using CSharpFunctionalExtensions.Internal;
 using System;
-using System.Collections.Generic;
 using System.Diagnostics;
-using System.Linq;
 using System.Runtime.Serialization;
 using System.Threading.Tasks;
 
 namespace CSharpFunctionalExtensions
 {
     [Serializable]
-    public struct Result : IResult, ISerializable
+    public partial struct Result : IResult, ISerializable
     {
         private static readonly Result OkResult = new Result(false, null);
 
@@ -221,56 +219,6 @@ public static Result FirstFailureOrSuccess(params Result[] results)
             return Ok();
         }
 
-        [DebuggerStepThrough]
-        public static Result Combine(IEnumerable<Result> results, string errorMessagesSeparator = null)
-        {
-            List<Result> failedResults = results.Where(x => x.IsFailure).ToList();
-
-            if (failedResults.Count == 0)
-                return Ok();
-
-            string errorMessage = string.Join(errorMessagesSeparator ?? ErrorMessagesSeparator, failedResults.Select(x => x.Error));
-            return Fail(errorMessage);
-        }
-
-        [DebuggerStepThrough]
-        public static Result Combine<T>(IEnumerable<Result<T>> results, string errorMessagesSeparator = null)
-        {
-            var untyped = results.Select(result => (Result)result);
-            return Combine(untyped, errorMessagesSeparator);
-        }
-
-        /// <summary>
-        /// Combines several results (and any error messages) into a single result.
-        /// The returned result will be a failure if any of the input <paramref name="results"/> are failures.
-        /// Error messages are concatenated with the default <see cref="Result.ErrorMessagesSeparator" /> between each message.
-        /// </summary>
-        /// <param name="results">The Results to be combined.</param>
-        /// <returns>A Result that is a success when all the input <paramref name="results"/> are also successes.</returns>
-        [DebuggerStepThrough]
-        public static Result Combine(params Result[] results)
-            => Combine(results, ErrorMessagesSeparator);
-
-        /// <summary>
-        /// Combines several results (and any error messages) into a single result.
-        /// The returned result will be a failure if any of the input <paramref name="results"/> are failures.
-        /// Error messages are concatenated with the specified <paramref name="errorMessagesSeparator"/> between each message.
-        /// </summary>
-        /// <param name="errorMessagesSeparator">The string to use as a separator. If omitted, the default <see cref="Result.ErrorMessagesSeparator" /> is used instead.</param>
-        /// <param name="results">The Results to be combined.</param>
-        /// <returns>A Result that is a success when all the input <paramref name="results"/> are also successes.</returns>
-        [DebuggerStepThrough]
-        public static Result Combine(string errorMessagesSeparator, params Result[] results)
-            => Combine(results, errorMessagesSeparator);
-
-        [DebuggerStepThrough]
-        public static Result Combine<T>(params Result<T>[] results)
-            => Combine(results, ErrorMessagesSeparator);
-
-        [DebuggerStepThrough]
-        public static Result Combine<T>(string errorMessagesSeparator, params Result<T>[] results)
-            => Combine(results, errorMessagesSeparator);
-
         private static readonly Func<Exception, string> DefaultTryErrorHandler = exc => exc.Message;
 
         public static Result Try(Action action, Func<Exception, string> errorHandler = null)

CSharpFunctionalExtensionsNet4.0/CSharpFunctionalExtensionsNet4.0.csproj

@@ -63,6 +63,7 @@
     <Compile Include="..\CSharpFunctionalExtensions\Result\Extensions\TapAsyncRight.cs" Link="Result\Extensions\TapAsyncRight.cs" />
     <Compile Include="..\CSharpFunctionalExtensions\Result\Internal\ResultCommonLogic.cs" Link="Result\Internal\ResultCommonLogic.cs" />
     <Compile Include="..\CSharpFunctionalExtensions\Result\Internal\ResultMessages.cs" Link="Result\Internal\ResultMessages.cs" />
+    <Compile Include="..\CSharpFunctionalExtensions\Result\Methods\Combine.cs" Link="Result\Methods\Combine.cs" />
     <Compile Include="..\CSharpFunctionalExtensions\Result\IResult.cs" Link="Result\IResult.cs" />
     <Compile Include="..\CSharpFunctionalExtensions\Result\Result.cs" Link="Result\Result.cs" />
     <Compile Include="..\CSharpFunctionalExtensions\Result\ResultT.cs" Link="Result\ResultT.cs" />