Skip to content

Commit 1f16685

Browse files
committed
Ok() - move to separate file
1 parent 8dd9180 commit 1f16685

File tree

3 files changed

+26
-19
lines changed

3 files changed

+26
-19
lines changed
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
using System.Diagnostics;
2+
3+
namespace CSharpFunctionalExtensions
4+
{
5+
public partial struct Result
6+
{
7+
[DebuggerStepThrough]
8+
public static Result Ok()
9+
{
10+
return new Result(false, null);
11+
}
12+
13+
[DebuggerStepThrough]
14+
public static Result<T> Ok<T>(T value)
15+
{
16+
return new Result<T>(false, value, null);
17+
}
18+
19+
[DebuggerStepThrough]
20+
public static Result<T, E> Ok<T, E>(T value)
21+
{
22+
return new Result<T, E>(false, value, default(E));
23+
}
24+
}
25+
}

CSharpFunctionalExtensions/Result/Result.cs

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ namespace CSharpFunctionalExtensions
99
[Serializable]
1010
public partial struct Result : IResult, ISerializable
1111
{
12-
private static readonly Result OkResult = new Result(false, null);
13-
1412
public static string ErrorMessagesSeparator = ", ";
1513
public static bool DefaultConfigureAwait = false;
1614

@@ -40,11 +38,6 @@ private Result(bool isFailure, string error)
4038
_logic = ResultCommonLogic.Create(isFailure, error);
4139
}
4240

43-
[DebuggerStepThrough]
44-
public static Result Ok()
45-
{
46-
return OkResult;
47-
}
4841

4942
[DebuggerStepThrough]
5043
public static Result Fail(string error)
@@ -93,12 +86,6 @@ public static async Task<Result> CreateFailure(Func<Task<bool>> failurePredicate
9386
: Ok();
9487
}
9588

96-
[DebuggerStepThrough]
97-
public static Result<T> Ok<T>(T value)
98-
{
99-
return new Result<T>(false, value, null);
100-
}
101-
10289
[DebuggerStepThrough]
10390
public static Result<T> Fail<T>(string error)
10491
{
@@ -145,12 +132,6 @@ public static async Task<Result<T>> CreateFailure<T>(Func<Task<bool>> failurePre
145132
: Ok<T>(value);
146133
}
147134

148-
[DebuggerStepThrough]
149-
public static Result<T, E> Ok<T, E>(T value)
150-
{
151-
return new Result<T, E>(false, value, default(E));
152-
}
153-
154135
[DebuggerStepThrough]
155136
public static Result<T, E> Fail<T, E>(E error)
156137
{

CSharpFunctionalExtensionsNet4.0/CSharpFunctionalExtensionsNet4.0.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@
6464
<Compile Include="..\CSharpFunctionalExtensions\Result\Internal\ResultCommonLogic.cs" Link="Result\Internal\ResultCommonLogic.cs" />
6565
<Compile Include="..\CSharpFunctionalExtensions\Result\Internal\ResultMessages.cs" Link="Result\Internal\ResultMessages.cs" />
6666
<Compile Include="..\CSharpFunctionalExtensions\Result\Methods\Combine.cs" Link="Result\Methods\Combine.cs" />
67+
<Compile Include="..\CSharpFunctionalExtensions\Result\Methods\Ok.cs" Link="Result\Methods\Ok.cs" />
6768
<Compile Include="..\CSharpFunctionalExtensions\Result\Methods\Try.cs" Link="Result\Methods\Try.cs" />
6869
<Compile Include="..\CSharpFunctionalExtensions\Result\IResult.cs" Link="Result\IResult.cs" />
6970
<Compile Include="..\CSharpFunctionalExtensions\Result\Result.cs" Link="Result\Result.cs" />

0 commit comments

Comments
 (0)