Fix: Apply code formatting Using black

Author: vishalpal-06

.coverage

@@ -7,8 +7,20 @@ on:
     branches: ["main"]
 
 jobs:
+  format-check:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Run Black code formatter check
+        uses: psf/black@stable
+        with:
+          check: true
+  
   test:
     runs-on: ubuntu-latest
+    needs: format-check
 
     steps:
       - name: Checkout code
@@ -25,6 +37,6 @@ jobs:
           pip install -r requirements.txt
           pip install pytest pytest-cov
 
-      - name: Run tests
+      - name: Run tests and coverage check
         run: |
           pytest --disable-warnings --maxfail=1 --cov=.

.github/workflows/ci.yaml

@@ -4,4 +4,7 @@ pytest --disable-warnings
 
 pytest --cov=.
 
-coverage html
+coverage html
+
+
+pytest --disable-warnings --maxfail=1 --cov=. --cov-fail-under=100

README.md

@@ -12,25 +12,23 @@
 
 # === USER: CREATE ===
 def create_attendance(db: Session, punch_time, current_user: dict) -> Attendance:
-    new_att = Attendance(
-        punch_time=punch_time,
-        fk_employee_id=current_user["id"]
-    )
+    new_att = Attendance(punch_time=punch_time, fk_employee_id=current_user["id"])
     db.add(new_att)
     db.commit()
     return new_att
 
 
 # === USER: READ OWN ===
 def get_my_attendance_all(db: Session, current_user: dict) -> List[Attendance]:
-    return db.query(Attendance).filter(Attendance.fk_employee_id == current_user["id"]).all()
+    return (
+        db.query(Attendance)
+        .filter(Attendance.fk_employee_id == current_user["id"])
+        .all()
+    )
 
-    
 
 def get_my_attendance_by_date(
-    db: db_dependency,
-    user: user_dependency,
-    punch_date: date
+    db: db_dependency, user: user_dependency, punch_date: date
 ):
     start_dt = datetime.combine(punch_date, time.min)
     end_dt = datetime.combine(punch_date, time.max)
@@ -40,34 +38,32 @@ def get_my_attendance_by_date(
         .filter(
             Attendance.fk_employee_id == user["id"],
             Attendance.punch_time >= start_dt,
-            Attendance.punch_time <= end_dt
+            Attendance.punch_time <= end_dt,
         )
         .order_by(Attendance.punch_time)
         .all()
     )
 
 
-
-
 # MANAGER: All direct reports' attendance on a given date
 def get_manager_team_attendance_by_date(
     punch_date: date,
     db: Session,
     user: dict,
 ) -> List[Attendance]:
     # Real check: does ANY employee report to this user?
-    has_subordinates = db.query(Employee).filter(
-        Employee.fk_manager_id == user["id"]
-    ).first()
+    has_subordinates = (
+        db.query(Employee).filter(Employee.fk_manager_id == user["id"]).first()
+    )
 
     if not has_subordinates:
         return []  # No one reports to you → empty list (safe)
 
     managed_ids = [
-        e.employee_id for e in
-        db.query(Employee.employee_id)
-          .filter(Employee.fk_manager_id == user["id"])
-          .all()
+        e.employee_id
+        for e in db.query(Employee.employee_id)
+        .filter(Employee.fk_manager_id == user["id"])
+        .all()
     ]
 
     start_dt = datetime.combine(punch_date, time.min)
@@ -77,7 +73,7 @@ def get_manager_team_attendance_by_date(
         db.query(Attendance)
         .filter(
             Attendance.fk_employee_id.in_(managed_ids),
-            Attendance.punch_time.between(start_dt, end_dt)
+            Attendance.punch_time.between(start_dt, end_dt),
         )
         .order_by(Attendance.fk_employee_id, Attendance.punch_time)
         .all()
@@ -92,15 +88,17 @@ def get_manager_subordinate_attendance_by_date(
     user: dict,
 ) -> List[Attendance]:
     # Security: employee must exist AND report directly to current user
-    employee = db.query(Employee).filter(
-        Employee.employee_id == employee_id,
-        Employee.fk_manager_id == user["id"]
-    ).first()
+    employee = (
+        db.query(Employee)
+        .filter(
+            Employee.employee_id == employee_id, Employee.fk_manager_id == user["id"]
+        )
+        .first()
+    )
 
     if not employee:
         raise HTTPException(
-            status_code=404,
-            detail="Employee not found under your management"
+            status_code=404, detail="Employee not found under your management"
         )
 
     start_dt = datetime.combine(punch_date, time.min)
@@ -110,39 +108,43 @@ def get_manager_subordinate_attendance_by_date(
         db.query(Attendance)
         .filter(
             Attendance.fk_employee_id == employee_id,
-            Attendance.punch_time.between(start_dt, end_dt)
+            Attendance.punch_time.between(start_dt, end_dt),
         )
         .order_by(Attendance.punch_time)
         .all()
     )
 
+
 # === ADMIN: READ ALL ===
 def get_all_attendance(db: Session, user: user_dependency):
     _require_admin(user=user)
     return db.query(Attendance).all()
 
 
-def get_attendance_by_date_all_employees(db: Session, punch_date: datetime, user: user_dependency):
+def get_attendance_by_date_all_employees(
+    db: Session, punch_date: datetime, user: user_dependency
+):
     _require_admin(user=user)
     start_dt = datetime.combine(punch_date, time.min)
     end_dt = datetime.combine(punch_date, time.max)
 
     return (
         db.query(Attendance)
-        .filter(
-            Attendance.punch_time >= start_dt,
-            Attendance.punch_time <= end_dt
-        )
+        .filter(Attendance.punch_time >= start_dt, Attendance.punch_time <= end_dt)
         .order_by(Attendance.punch_time)
         .all()
     )
 
 
-def get_attendance_by_date_one_employee(db: Session, employee_id: int, punch_date: datetime, user:user_dependency):
+def get_attendance_by_date_one_employee(
+    db: Session, employee_id: int, punch_date: datetime, user: user_dependency
+):
     _require_admin(user=user)
     employee = db.query(Employee).filter(Employee.employee_id == employee_id).first()
     if not employee:
-        raise HTTPException(status_code=status.HTTP_404_NOT_FOUND,detail="Employee not found")
+        raise HTTPException(
+            status_code=status.HTTP_404_NOT_FOUND, detail="Employee not found"
+        )
     start_dt = datetime.combine(punch_date, time.min)
     end_dt = datetime.combine(punch_date, time.max)
 
@@ -158,13 +160,16 @@ def get_attendance_by_date_one_employee(db: Session, employee_id: int, punch_dat
     )
 
 
-def get_all_attendance_of_employee(db: Session, employee_id: int, user:user_dependency):
+def get_all_attendance_of_employee(
+    db: Session, employee_id: int, user: user_dependency
+):
     _require_admin(user=user)
-    employee = db.query(Employee).filter(Employee.employee_id==employee_id).first()
+    employee = db.query(Employee).filter(Employee.employee_id == employee_id).first()
     if not employee:
-        raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail="Employee Not Founds")
-    records = db.query(Attendance).filter(Attendance.fk_employee_id == employee_id).all()
+        raise HTTPException(
+            status_code=status.HTTP_404_NOT_FOUND, detail="Employee Not Founds"
+        )
+    records = (
+        db.query(Attendance).filter(Attendance.fk_employee_id == employee_id).all()
+    )
     return records
-
-
-

common/attendance.py

@@ -1,8 +1,8 @@
 from fastapi import HTTPException, status
 
+
 def _require_admin(user: dict):
     if not user.get("is_admin"):
         raise HTTPException(
-            status_code=status.HTTP_403_FORBIDDEN,
-            detail="Admin privileges required"
+            status_code=status.HTTP_403_FORBIDDEN, detail="Admin privileges required"
         )

common/common.py

@@ -7,17 +7,21 @@
 from common.common import _require_admin
 
 
-
-
 def _get_department_by_id(db: db_dependency, department_id: int) -> Department:
-    department = db.query(Department).filter(Department.department_id == department_id).first()
+    department = (
+        db.query(Department).filter(Department.department_id == department_id).first()
+    )
     if not department:
         raise HTTPException(status_code=404, detail="Department not found")
     return department
 
 
 def _get_department_by_name(db: db_dependency, department_name: str) -> Department:
-    department = db.query(Department).filter(Department.department_name.ilike(department_name.strip())).first()
+    department = (
+        db.query(Department)
+        .filter(Department.department_name.ilike(department_name.strip()))
+        .first()
+    )
     if not department:
         raise HTTPException(status_code=404, detail="Department not found")
     return department
@@ -33,10 +37,16 @@ def get_department_by_id(db: db_dependency, department_id: int):
 
 
 # === ADMIN: CREATE ===
-def create_department(db: db_dependency, department_name: str, user: dict) -> Department:
+def create_department(
+    db: db_dependency, department_name: str, user: dict
+) -> Department:
     _require_admin(user)
     department_name = department_name.strip()
-    if db.query(Department).filter(Department.department_name.ilike(department_name)).first():
+    if (
+        db.query(Department)
+        .filter(Department.department_name.ilike(department_name))
+        .first()
+    ):
         raise HTTPException(status_code=400, detail="Department already exists")
 
     new_department = Department(department_name=department_name)
@@ -46,35 +56,55 @@ def create_department(db: db_dependency, department_name: str, user: dict) -> De
 
 
 # === ADMIN: UPDATE BY ID ===
-def update_department_by_id(db: db_dependency, department_id: int, new_department_name: str, user: dict) -> Department:
+def update_department_by_id(
+    db: db_dependency, department_id: int, new_department_name: str, user: dict
+) -> Department:
     _require_admin(user)
     department = _get_department_by_id(db, department_id)
 
     new_name = new_department_name.strip()
-    if db.query(Department).filter(Department.department_name.ilike(new_name), Department.department_id != department_id).first():
-        raise HTTPException(status_code=400, detail="Department with this name already exists")
+    if (
+        db.query(Department)
+        .filter(
+            Department.department_name.ilike(new_name),
+            Department.department_id != department_id,
+        )
+        .first()
+    ):
+        raise HTTPException(
+            status_code=400, detail="Department with this name already exists"
+        )
 
     department.department_name = new_name
     db.commit()
     return department
 
 
 # === ADMIN: UPDATE BY NAME ===
-def update_department_by_name(db: db_dependency, current_department_name: str, new_department_name: str, user: dict) -> Department:
+def update_department_by_name(
+    db: db_dependency,
+    current_department_name: str,
+    new_department_name: str,
+    user: dict,
+) -> Department:
     _require_admin(user)
     department = _get_department_by_name(db, current_department_name)
 
     new_name = new_department_name.strip()
     if db.query(Department).filter(Department.department_name.ilike(new_name)).first():
-        raise HTTPException(status_code=400, detail="Department with this name already exists")
+        raise HTTPException(
+            status_code=400, detail="Department with this name already exists"
+        )
 
     department.department_name = new_name
     db.commit()
     return department
 
 
 # === ADMIN: DELETE BY ID ===
-def delete_department_by_id(db: db_dependency, department_id: int, user: dict) -> Dict[str, str]:
+def delete_department_by_id(
+    db: db_dependency, department_id: int, user: dict
+) -> Dict[str, str]:
     _require_admin(user)
     department = _get_department_by_id(db, department_id)
     db.delete(department)
@@ -83,9 +113,11 @@ def delete_department_by_id(db: db_dependency, department_id: int, user: dict) -
 
 
 # === ADMIN: DELETE BY NAME ===
-def delete_department_by_name(db: db_dependency, department_name: str, user: dict) -> Dict[str, str]:
+def delete_department_by_name(
+    db: db_dependency, department_name: str, user: dict
+) -> Dict[str, str]:
     _require_admin(user)
     department = _get_department_by_name(db, department_name)
     db.delete(department)
     db.commit()
-    return {"detail": "Department deleted successfully"}
+    return {"detail": "Department deleted successfully"}