false task config being overwritten by empty array resulting in task being performed

Author: kasparsz

CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [1.6.1] - 2022-10-21
+### Fixed
+- `false` task config being overwritten by empty array resulting in task being performed
+
 ## [1.6.0] - 2022-06-20
 ### Updated
 - gulp-sass to use latest node-sass version

lib/get-config.js

@@ -85,6 +85,7 @@ function getTaskConfig (...path) {
  * @protected
  */
 function itterateConfig (config, fn) {
+    if (config === false) return false;
     const base = isPlainObject(config) ? {} : [];
 
     return reduce(config, (object, value, key) => {
@@ -111,7 +112,13 @@ function itterateConfig (config, fn) {
 function mergeConfigMode (config) {
     if ('production' in config || 'development' in config) {
         const mode = global.production ? 'production' : 'development';
-        return omit(merge(config, config[mode]), ['production', 'development']);
+        const value = merge(config, config[mode]);
+
+        if (value !== false) {
+            return omit(value, ['production', 'development']);
+        } else {
+            return value;
+        }
     } else {
         return config;
     }

lib/merge.js

@@ -17,7 +17,11 @@ function customizer (objValue, srcValue, key) {
  */
 module.exports = function merge (object, ...sources) {
     for (let i = 0; i < sources.length; i++) {
-        object = mergeWith(object, sources[i], customizer);
+        if (sources[i] && typeof sources[i] === 'object') {
+            object = mergeWith(object, sources[i], customizer);
+        } else {
+            object = sources[i];
+        }
     }
     return object;
 }

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@videinfra/static-website-builder",
-  "version": "1.6.0",
+  "version": "1.6.1",
   "description": "Customizable static site project builder",
   "license": "MIT",
   "engines": {