fix tests

Author: vigo

internal/stringutils/stringutils.go

@@ -18,12 +18,22 @@ const (
 	modHundred = 100
 )
 
-var illegalChars = regexp.MustCompile(`[<>:"/\\|?*\s]+`)
+func illegalChars() *regexp.Regexp {
+	return regexp.MustCompile(`[<>:"/\\|?*\s]+`)
+}
+
+// NowFunc is used to get the current time. It defaults to time.Now, but
+// can be overridden in tests.
+var NowFunc = time.Now
+
+// UserHomeDirFunc is used to get the user's home directory.
+// It defaults to os.UserHomeDir but can be overridden in tests.
+var UserHomeDirFunc = os.UserHomeDir
 
 // FormatDate formats given date as Django's format date style (most of them).
 // https://docs.djangoproject.com/en/5.1/ref/templates/builtins/#date
 func FormatDate(format string, date *time.Time) string {
-	d := time.Now()
+	d := NowFunc()
 	if date != nil {
 		d = *date
 	}
@@ -84,7 +94,7 @@ func FormatDate(format string, date *time.Time) string {
 }
 
 func sanitizeFilename(input string) string {
-	return illegalChars.ReplaceAllString(input, "_")
+	return illegalChars().ReplaceAllString(input, "_")
 }
 
 // GetFormattedFilename returns formated filename.
@@ -103,8 +113,10 @@ func GetFormattedFilename(s string, req *http.Request) string {
 	sArgs := argReplacer.Replace(s)
 
 	if strings.HasPrefix(sArgs, "~") {
-		home, err := os.UserHomeDir()
+		home, err := UserHomeDirFunc()
 		if err != nil {
+			sArgs = sArgs[1:]
+
 			goto RETURN
 		}
 

internal/stringutils/stringutils_test.go

@@ -1,6 +1,7 @@
 package stringutils_test
 
 import (
+	"errors"
 	"net/http"
 	"net/url"
 	"testing"
@@ -136,6 +137,17 @@ func parseDateWithNanoseconds(dateString string) *time.Time {
 }
 
 func TestGetFormattedFilename(t *testing.T) {
+	fixedTime := time.Date(2024, time.December, 26, 15, 0, 0, 0, time.UTC)
+	originalNowFunc := stringutils.NowFunc
+	stringutils.NowFunc = func() time.Time { return fixedTime }
+	defer func() { stringutils.NowFunc = originalNowFunc }()
+
+	originalHomeDirFunc := stringutils.UserHomeDirFunc
+	stringutils.UserHomeDirFunc = func() (string, error) {
+		return "/home/testuser", nil
+	}
+	defer func() { stringutils.UserHomeDirFunc = originalHomeDirFunc }()
+
 	tests := []struct {
 		name     string
 		format   string
@@ -151,6 +163,15 @@ func TestGetFormattedFilename(t *testing.T) {
 			},
 			expected: "2024-12-26-localhost_9000-_example_path.raw",
 		},
+		{
+			name:   "Basic formatting with sanitized hostname and URL under home",
+			format: "~/%Y-%m-%d-{hostname}-{url}.raw",
+			req: &http.Request{
+				Host: "localhost:9000",
+				URL:  &url.URL{Path: "/example/path"},
+			},
+			expected: "/home/testuser/2024-12-26-localhost_9000-_example_path.raw",
+		},
 		{
 			name:   "Special characters in hostname and URL",
 			format: "%Y-%m-%d-%F-{hostname}-{url}.raw",
@@ -196,3 +217,26 @@ func TestGetFormattedFilename(t *testing.T) {
 		})
 	}
 }
+
+func TestGetFormattedFilename_HomeErr(t *testing.T) {
+	fixedTime := time.Date(2024, time.December, 26, 15, 0, 0, 0, time.UTC)
+	originalNowFunc := stringutils.NowFunc
+	stringutils.NowFunc = func() time.Time { return fixedTime }
+	defer func() { stringutils.NowFunc = originalNowFunc }()
+
+	originalHomeDirFunc := stringutils.UserHomeDirFunc
+	stringutils.UserHomeDirFunc = func() (string, error) {
+		return "", errors.New("error")
+	}
+	defer func() { stringutils.UserHomeDirFunc = originalHomeDirFunc }()
+
+	format := "~/%Y-%m-%d-{hostname}-{url}.raw"
+	req := &http.Request{
+		Host: "localhost:9000",
+		URL:  &url.URL{Path: "/example/path"},
+	}
+	expected := "/2024-12-26-localhost_9000-_example_path.raw"
+
+	result := stringutils.GetFormattedFilename(format, req)
+	assert.Equal(t, expected, result)
+}