symfony/console >= 7 compatibility

[KDederichs]

Is your feature request related to a problem? Please describe.
Now that Symfony 8 is out, it would be nice to have a version of this package that supports symfony console 7 and up.

Describe the solution you'd like
Since you're worried about BC I'd suggest tagging a version that supports this as 6.0 and all the older installations can still use the old version that supports it.

Describe alternatives you've considered
Funny enough I'm already using the version of this library that doesn't restrict symfony/console to < 7 with 7.2 /7.3/7.4 for quite a while now and it seems to work just fine so maybe at least change it to <8 ? (Though 8 support would still be nice)

[jooname]

This is definitely something we will eventually look into. As you likely have already figured out, the strict version requirement was added in #125 since newer versions of symfony/console have changes in the command classes that are not compatible with the code in the package. Without the explicit version limitation, the version of symfony/console installed can be too new (as noticed through the workflows we've added here), which then results in the package not working. The compatibilities are very trivial to fix, but will indeed drop backwards compatibility. Creating a new major version is one option for sure, but we want to see if there's other alternatives.

[KDederichs]

Yeah I remember that being a thing back then....
I also remember some package I was using had some BC stuff for it, I think it was as simple as just using the Annotation or something?

It's been too long though so I can't tell you who it was anymore sadly otherwise I'd have looked it up.

Can you maybe point me to where the stuff that's having issues is? (Console Namespace for one maybe?).
I'll try to come up with some non BC breaking solution when I have time.

[jooname]

At the very least anything extending Composer\Command\BaseCommand (which extends Symfony\Component\Console\Command\Command) is affected. So everything under src/Composer/Commands.

Installing the package with PHP 8.4 and Composer 2.8, with no symfony/console restriction gives this error, if you attempt to run any of the commands added by the package:

PHP Fatal error:  Declaration of Vaimo\ComposerPatches\Composer\Commands\PatchCommand::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) must be compatible with Symfony\Component\Console\Command\Command::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output): int in /module/src/Composer/Commands/PatchCommand.php on line 118

Following can also come up with some older patch versions of Composer 2.8, but it's related to Composer itself and is solved in newer patch versions so no concern with this package. Might need to keep in mind with testsuite, if it comes up.

Deprecation Notice: Since symfony/console 7.4: The "Symfony\Component\Console\Application::add()" method is deprecated and will be removed in Symfony 8.0, use "Symfony\Component\Console\Application::addCommand()" instead. in /module/vendor/symfony/deprecation-contracts/function.php:25

Other than those it seems like the testsuite runs through successfully (as long as both are solved somehow that is), so dealing with the method declaration compatibilities in backwards compatible manner is the only thing to do here.