Skip to content

Conversation

@david-cortes-intel
Copy link
Contributor

Description

This PR fixes an issue with IncrementalPCA in which cases that issue warning about the data were issuing such warning on each batch of data, since each of them validates the data again and again.

This PR fixes it by validating the data only once, which also comes with performance improvements. Note that while this hard-codes check_input=False, it only happens after a first call to validate_data.

It fixes a failed conformance tests from sklearn1.8 that was erroring out due to expecting only one warning instead of multiple repeated ones.


Checklist:

Completeness and readability

  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
azure 80.43% <ø> (ø)
github 82.04% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-cortes-intel david-cortes-intel merged commit fe0a2ed into uxlfoundation:main Dec 2, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sklearn-patch sklearn patching

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants