FIX: Fix multiple warnings being issued in batched PCA #2811
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue with
IncrementalPCAin which cases that issue warning about the data were issuing such warning on each batch of data, since each of them validates the data again and again.This PR fixes it by validating the data only once, which also comes with performance improvements. Note that while this hard-codes
check_input=False, it only happens after a first call tovalidate_data.It fixes a failed conformance tests from sklearn1.8 that was erroring out due to expecting only one warning instead of multiple repeated ones.
Checklist:
Completeness and readability
Testing