Skip to content

Conversation

@david-cortes-intel
Copy link
Contributor

@david-cortes-intel david-cortes-intel commented Nov 28, 2025

Description

Skips some new sklearn1.8 tests that fail due to small numeric differences.

Disclaimer: I'm not 100% sure that this is within expected ranges of numeric differences. Error log that this "solves" is as follows:

>               assert line.get_label() == aggregate_expected_labels[idx]
E               AssertionError: assert 'AUC = 0.61 +/- 0.04' == 'AUC = 0.61 +/- 0.05'
E                 
E                 - AUC = 0.61 +/- 0.05
E                 ?                   ^
E                 + AUC = 0.61 +/- 0.04
E                 ?                   ^

So we can only see 2 decimal points. There shouldn't be a difference of 0.01 between implementations, but perhaps it might be that it's too close to the rounding boundary and the difference is actually smaller.

The difference comes from results produced by LogisticRegression, not from the patched AUROC functionality.


Checklist:

Completeness and readability

  • I have commented my code, particularly in hard-to-understand areas.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • All CI jobs are green or I have provided justification why they aren't.

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
azure 80.43% <ø> (ø)
github ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant