Support c2a-core v4.4.0 (C2A command sender) #610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltingrabbit
requested review from
200km,
conjikidow,
seki-hiro,
suzuki-toshihir0 and
t-hosonuma
and removed request for
a team
2 tasks
200km
added
priority::medium
Member
|
@meltingrabbit #619 がマージされましたが、こちらはどうしますか？ isslのレビューはあとでと言われているので、レビューしていませんが必要ならレビューはすぐにでもできます。 |
Contributor
Author
|
@200km ありがとうございます． |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
NA
Description
After c2a-core v4.4.0, the common packet source code directory will be changed (arkedge/c2a-core#310).
The C2A command sender (#485) is an experimental feature that temporarily includes header file of C2A util function directly, but arkedge/c2a-core#310 is a breaking change to this feature.
Therefore, add a conditional branch to change the include path depending on the version of c2a-core.
Test results
NA
Impact
Supplementary information
NA
備考
まず @sksat のレビューで議論後， @ut-issl/aocs のレビューをもらいたいです．