style: move code to impl files

Author: qubka

include/plugify/config.hpp

@@ -191,225 +191,10 @@ namespace plugify {
 		} logging;
 
 		// Comprehensive merge implementation
-		void MergeFrom(const Config& other, ConfigSource source = ConfigSource::Override) {
-			// Only merge if the new source has equal or higher priority
-
-			// Merge Paths
-			if (source >= _sources.paths) {
-				bool pathsChanged = false;
-
-				// Always take baseDir if provided
-				if (!other.paths.baseDir.empty()) {
-					paths.baseDir = other.paths.baseDir;
-					pathsChanged = true;
-				}
-
-				// Take other paths if they're customized
-				if (other.paths.HasCustomExtensionsDir()) {
-					paths.extensionsDir = other.paths.extensionsDir;
-					pathsChanged = true;
-				}
-				if (other.paths.HasCustomConfigsDir()) {
-					paths.configsDir = other.paths.configsDir;
-					pathsChanged = true;
-				}
-				if (other.paths.HasCustomDataDir()) {
-					paths.dataDir = other.paths.dataDir;
-					pathsChanged = true;
-				}
-				if (other.paths.HasCustomLogsDir()) {
-					paths.logsDir = other.paths.logsDir;
-					pathsChanged = true;
-				}
-				if (other.paths.HasCustomCacheDir()) {
-					paths.cacheDir = other.paths.cacheDir;
-					pathsChanged = true;
-				}
-
-				if (pathsChanged) {
-					_sources.paths = source;
-				}
-			}
-
-			// Merge Loading
-			if (source >= _sources.loading) {
-				bool loadingChanged = false;
-
-				if (other.loading.HasCustomPreferOwnSymbols()) {
-					loading.preferOwnSymbols = other.loading.preferOwnSymbols;
-					loadingChanged = true;
-				}
-				if (other.loading.HasCustomMaxConcurrentLoads()) {
-					loading.maxConcurrentLoads = other.loading.maxConcurrentLoads;
-					loadingChanged = true;
-				}
-				if (other.loading.HasCustomLoadTimeout()) {
-					loading.loadTimeout = other.loading.loadTimeout;
-					loadingChanged = true;
-				}
-				if (other.loading.HasCustomExportTimeout()) {
-					loading.exportTimeout = other.loading.exportTimeout;
-					loadingChanged = true;
-				}
-				if (other.loading.HasCustomStartTimeout()) {
-					loading.startTimeout = other.loading.startTimeout;
-					loadingChanged = true;
-				}
-
-				if (loadingChanged) {
-					_sources.loading = source;
-				}
-			}
-
-			// Merge Runtime
-			if (source >= _sources.runtime) {
-				bool runtimeChanged = false;
-
-				if (other.runtime.HasCustomUpdateMode()) {
-					runtime.updateMode = other.runtime.updateMode;
-					runtimeChanged = true;
-				}
-				if (other.runtime.HasCustomUpdateInterval()) {
-					runtime.updateInterval = other.runtime.updateInterval;
-					runtimeChanged = true;
-				}
-				if (other.runtime.updateCallback) {
-					runtime.updateCallback = other.runtime.updateCallback;
-					runtimeChanged = true;
-				}
-				if (other.runtime.HasCustomPinToMainThread()) {
-					runtime.pinToMainThread = other.runtime.pinToMainThread;
-					runtimeChanged = true;
-				}
-				if (other.runtime.HasThreadPriority()) {
-					runtime.threadPriority = other.runtime.threadPriority;
-					runtimeChanged = true;
-				}
-
-				if (runtimeChanged) {
-					_sources.runtime = source;
-				}
-			}
-
-			// Merge Security
-			if (source >= _sources.security) {
-				bool securityChanged = false;
-
-				// For sets, we have different merge strategies
-				if (source == ConfigSource::Override) {
-					// Override replaces entirely if non-empty
-					if (other.security.HasWhitelist()) {
-						security.whitelistedExtensions = other.security.whitelistedExtensions;
-						securityChanged = true;
-					}
-					if (other.security.HasBlacklist()) {
-						security.blacklistedExtensions = other.security.blacklistedExtensions;
-						securityChanged = true;
-					}
-					if (other.security.HasExcluded()) {
-						security.excludedDirs = other.security.excludedDirs;
-						securityChanged = true;
-					}
-				} else {
-					// Other sources merge/append
-					if (other.security.HasWhitelist()) {
-						security.whitelistedExtensions.insert(
-						    other.security.whitelistedExtensions.begin(),
-						    other.security.whitelistedExtensions.end()
-						);
-						securityChanged = true;
-					}
-					if (other.security.HasBlacklist()) {
-						security.blacklistedExtensions.insert(
-						    other.security.blacklistedExtensions.begin(),
-						    other.security.blacklistedExtensions.end()
-						);
-						securityChanged = true;
-					}
-					if (other.security.HasExcluded()) {
-						security.excludedDirs.insert(
-						    other.security.excludedDirs.begin(),
-						    other.security.excludedDirs.end()
-						);
-						securityChanged = true;
-					}
-				}
-
-				if (securityChanged) {
-					_sources.security = source;
-				}
-			}
-
-			// Merge Logging
-			if (source >= _sources.logging) {
-				bool loggingChanged = false;
-
-				if (other.logging.HasCustomSeverity()) {
-					logging.severity = other.logging.severity;
-					loggingChanged = true;
-				}
-				if (other.logging.HasCustomPrintReport()) {
-					logging.printReport = other.logging.printReport;
-					loggingChanged = true;
-				}
-				if (other.logging.HasCustomPrintLoadOrder()) {
-					logging.printLoadOrder = other.logging.printLoadOrder;
-					loggingChanged = true;
-				}
-				if (other.logging.HasCustomPrintDependencyGraph()) {
-					logging.printDependencyGraph = other.logging.printDependencyGraph;
-					loggingChanged = true;
-				}
-				if (other.logging.HasCustomPrintDigraphDot()) {
-					logging.printDigraphDot = other.logging.printDigraphDot;
-					loggingChanged = true;
-				}
-				if (other.logging.HasExportPath()) {
-					logging.exportDigraphDot = other.logging.exportDigraphDot;
-					loggingChanged = true;
-				}
-
-				if (loggingChanged) {
-					_sources.logging = source;
-				}
-			}
-
-			// Always resolve paths after merge
-			paths.ResolveRelativePaths();
-		}
+		void MergeFrom(const Config& other, ConfigSource source = ConfigSource::Override);
 
 		// Alternative merge for selective field updates
-		/*void MergeField(std::string_view fieldPath, const Config& other, ConfigSource source =
-		ConfigSource::Override) {
-		    // This allows merging specific fields only
-		    if (fieldPath == "paths") {
-		        if (source >= _sources.paths) {
-		            paths = other.paths;
-		            _sources.paths = source;
-		            paths.ResolveRelativePaths();
-		        }
-		    } else if (fieldPath == "loading") {
-		        if (source >= _sources.loading) {
-		            loading = other.loading;
-		            _sources.loading = source;
-		        }
-		    } else if (fieldPath == "runtime") {
-		        if (source >= _sources.runtime) {
-		            runtime = other.runtime;
-		            _sources.runtime = source;
-		        }
-		    } else if (fieldPath == "security") {
-		        if (source >= _sources.security) {
-		            security = other.security;
-		            _sources.security = source;
-		        }
-		    } else if (fieldPath == "logging") {
-		        if (source >= _sources.logging) {
-		            logging = other.logging;
-		            _sources.logging = source;
-		        }
-		    }
-		}
+		void MergeField(std::string_view fieldPath, const Config& other, ConfigSource source = ConfigSource::Override);
 
 		// Get effective source for debugging
 		std::string GetSourceInfo() const {
@@ -421,54 +206,15 @@ namespace plugify {
 		        plg::enum_to_string(_sources.security),
 		        plg::enum_to_string(_sources.logging)
 		    );
-		}*/
+		}
 
 		// Reset to defaults
 		void Reset() {
 			*this = Config{};
 		}
 
 		// Validation remains the same
-		Result<void> Validate() const {
-			if (paths.baseDir.empty()) {
-				return MakeError("Base directory not set");
-			}
-
-			// Check for path collisions
-			using pair = std::pair<std::string_view, const std::filesystem::path*>;
-			std::array pathList = {
-				pair{ "extensions", &paths.extensionsDir },
-				pair{ "configs", &paths.configsDir },
-				pair{ "data", &paths.dataDir },
-				pair{ "logs", &paths.logsDir },
-				pair{ "cache", &paths.cacheDir },
-			};
-
-			for (size_t i = 0; i < pathList.size(); ++i) {
-				for (size_t j = i + 1; j < pathList.size(); ++j) {
-					if (*pathList[i].second == *pathList[j].second) {
-						return MakeError(
-						    "{} and {} directories are the same: {}",
-						    pathList[i].first,
-						    pathList[j].first,
-						    plg::as_string(*pathList[i].second)
-						);
-					}
-				}
-			}
-
-			// Validate runtime config
-			if (runtime.updateMode == UpdateMode::BackgroundThread
-			    && runtime.updateInterval <= std::chrono::milliseconds{ 0 }) {
-				return MakeError("Invalid update interval for background thread mode");
-			}
-
-			if (runtime.updateMode == UpdateMode::Callback && !runtime.updateCallback) {
-				return MakeError("Update callback not set for callback mode");
-			}
-
-			return {};
-		}
+		Result<void> Validate() const;
 
 	private:
 		static inline std::unordered_set<std::filesystem::path> DefaultExcludedDirs = {