Add clang-tidy configuration and CI job

.clang-tidy

@@ -0,0 +1,12 @@
+---
+Checks: >
+  -*,
+  clang-analyzer-*,
+  clang-diagnostic-*,
+  bugprone-*,
+  performance-*
+WarningsAsErrors: '*'
+# Only analyze headers from this repository; ignore external headers
+HeaderFilterRegex: '^(include/|test/(?!third_party/))'
+FormatStyle: file
+...

.github/workflows/clang-tidy-review.yml

@@ -0,0 +1,25 @@
+name: clang-tidy-review
+
+on: [pull_request]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v4
+
+    # Optionally generate compile_commands.json
+    - uses: ZedThree/clang-tidy-review@v0.14.0
+      id: review
+      with:
+        cmake_command: cmake -S . -B build -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
+        build_dir: build
+
+    # Uploads an artefact containing clang_fixes.json
+    - uses: ZedThree/clang-tidy-review/upload@v0.14.0
+      id: upload-review
+
+    # If there are any comments, fail the check
+    - if: steps.review.outputs.total_comments > 0
+      run: exit 1

test/CMakeLists.txt

@@ -20,7 +20,8 @@ endif()
 function(make_test src target std)
     add_executable(${target} ${src})
     target_compile_options(${target} PRIVATE ${OPTIONS})
-    target_include_directories(${target} PRIVATE third_party/catch2)
+    target_include_directories(${target} SYSTEM PRIVATE third_party/catch2)
+    target_compile_definitions(${target} PRIVATE CATCH_CONFIG_NO_POSIX_SIGNALS)
     target_link_libraries(${target} PRIVATE ${CMAKE_PROJECT_NAME})
     set_target_properties(${target} PROPERTIES CXX_EXTENSIONS OFF)
     if(std)