Fix: return empty title if no head title element is found (#16)

Constantin Krüger · uniqueck · commit f6c34e4a2c1a · 2024-08-07T15:15:55.000+02:00
diff --git a/lib/html/htmlPage.js b/lib/html/htmlPage.js
@@ -21,7 +21,12 @@ class HtmlPage {
   }
 
   getTitle () {
-    return this.content.querySelector('html head title').innerHTML
+    const title = this.content.querySelector('html head title')
+    if (title) {
+      return title.innerHTML.trim()
+    } else {
+      return ''
+    }
   }
 
   getAllIds () {
diff --git a/test/node-unit/htmlPage.spec.js b/test/node-unit/htmlPage.spec.js
@@ -0,0 +1,71 @@
+/* global describe it */
+'use strict'
+
+const HtmlPage = require('../../lib/html/htmlPage')
+const chai = require('chai')
+const expect = chai.expect
+const HTMLParser = require('node-html-parser')
+
+describe('htmlPage', () => {
+  describe('title', () => {
+    it('missing', () => {
+      const htmlPage = new HtmlPage({
+        content: HTMLParser.parse(`<!DOCTYPE html>
+                <meta charset="utf-8">
+                <script>location="url/to/page.html"</script>
+                <meta http-equiv="refresh" content="0; url=url/to/page.html">
+                <meta name="robots" content="noindex">
+                <title>Redirect Notice</title>
+                <h1>Redirect Notice</h1>
+                <p>The page you requested has been relocated to <a href="url/to/page.html">url/to/page.html</a>.</p>
+            `
+        )
+      })
+      expect(htmlPage.getTitle()).eq('')
+    })
+    it('exists', () => {
+      const htmlPage = new HtmlPage({
+        content: HTMLParser.parse(`<!DOCTYPE html>
+                <html lang="en">
+                  <head>
+                    <meta charset="utf-8">
+                    <meta name="viewport" content="width=device-width,initial-scale=1">
+                    <title>Long Title with spaces</title>
+                    <meta name="generator" content="Antora 3.1.9">
+                    <link rel="stylesheet" href="../../antora/css/site.css">
+                    <link rel="stylesheet" href="../../antora/css/custom.css">
+                    <link rel="stylesheet" href="../../antora/css/font-awesome.min.css">
+                    <link rel="stylesheet" href="../../antora/css/extra.css">
+                    <script>var uiRootPath = '../../antora'</script>
+                  </head>
+                  <body></body>
+                </html>
+            `
+        )
+      })
+      expect(htmlPage.getTitle()).eq('Long Title with spaces')
+    })
+    it('long title with spaces around', () => {
+      const htmlPage = new HtmlPage({
+        content: HTMLParser.parse(`<!DOCTYPE html>
+            <html lang="en">
+              <head>
+                <meta charset="utf-8">
+                <meta name="viewport" content="width=device-width,initial-scale=1">
+                <title> Long Title with spaces around </title>
+                <meta name="generator" content="Antora 3.1.9">
+                <link rel="stylesheet" href="../../antora/css/site.css">
+                <link rel="stylesheet" href="../../antora/css/custom.css">
+                <link rel="stylesheet" href="../../antora/css/font-awesome.min.css">
+                <link rel="stylesheet" href="../../antora/css/extra.css">
+                <script>var uiRootPath = '../../antora'</script>
+              </head>
+              <body></body>
+            </html>
+        `
+        )
+      })
+      expect(htmlPage.getTitle()).eq('Long Title with spaces around')
+    })
+  })
+})

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,12 @@ class HtmlPage {`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`getTitle () {`
`24`		`- return this.content.querySelector('html head title').innerHTML`
	`24`	`+ const title = this.content.querySelector('html head title')`
	`25`	`+ if (title) {`
	`26`	`+ return title.innerHTML.trim()`
	`27`	`+ } else {`
	`28`	`+ return ''`
	`29`	`+ }`
`25`	`30`	`}`
`26`	`31`
`27`	`32`	`getAllIds () {`