Add initial tests

Author: Simen Brekken

.gitignore

@@ -1 +1,2 @@
-node_modules/
+coverage/
+node_modules/

package.json

@@ -39,7 +39,12 @@
     "eslint-plugin-react": "4.2.3",
     "express": "4.13.4",
     "express-urlrewrite": "1.2.0",
+    "isparta": "4.0.0",
+    "jsdom": "8.1.0",
+    "jsdom-global": "1.7.0",
+    "react-addons-test-utils": "0.14.7",
     "react-dom": "0.14.7",
+    "tape": "4.5.1",
     "webpack": "1.12.14",
     "webpack-dev-middleware": "1.5.1"
   },

src/components/connect.js

@@ -21,7 +21,7 @@ export default (mapPropsToSubscriptions, mapFirebaseToProps, mergeProps, options
   const mapFirebase = mapFirebaseToProps || defaultMapFirebaseToProps;
 
   const finalMergeProps = mergeProps || defaultMergeProps;
-  const { pure = true, keepalive = 2500 } = options;
+  const { pure = true, keepalive = 0 } = options;
 
   const computeSubscriptions = props => {
     const subscriptions = mapSubscriptions(props);
@@ -142,9 +142,13 @@ export default (mapPropsToSubscriptions, mapFirebaseToProps, mergeProps, options
         const subscriptionKeys = keys(subscriptions);
 
         this.listeners = reduce(subscriptionKeys, (listeners, key) => {
-          const listener = listeners[key];
+          const unsubscribeKey = () => listeners[key].unsubscribe();
 
-          setTimeout(() => listener.unsubscribe(), keepalive);
+          if (keepalive) {
+            setTimeout(unsubscribeKey, keepalive);
+          } else {
+            unsubscribeKey();
+          }
 
           return omit(listeners, key);
         }, this.listeners);

src/components/tests/connect-test.js

@@ -0,0 +1,114 @@
+import 'jsdom-global/register';
+import React from 'react';
+import test from 'tape';
+import { findDOMNode, unmountComponentAtNode } from 'react-dom';
+import { renderIntoDocument } from 'react-addons-test-utils';
+
+import connect from '../connect';
+
+test('Should throw if no firebase instance was found in either props or context', assert => {
+  assert.throws(() => {
+    const WrappedComponent = connect()('div');
+
+    renderIntoDocument(<WrappedComponent />);
+  }, /Could not find "firebase"/);
+
+  assert.end();
+});
+
+test('Should subscribe to a single path', assert => {
+  const mockFirebase = {
+    child: path => {
+      assert.equal(path, 'foo');
+
+      return mockFirebase;
+    },
+    on: (event, callback) => {
+      assert.equal(event, 'value');
+
+      const mockSnapshot = {
+        val: () => 'foo changed',
+      };
+
+      callback(mockSnapshot);
+    },
+  };
+
+  const mapPropsToSubscriptions = () => ({ foo: 'foo' });
+  const WrappedComponent = connect(mapPropsToSubscriptions)('div');
+  const container = renderIntoDocument(<WrappedComponent firebase={mockFirebase} />);
+
+  assert.deepEqual(container.state.subscriptionsState, { foo: 'foo changed' });
+  assert.end();
+});
+
+test('Should subscribe to a query', assert => {
+  const mockFirebase = {
+    child: () => {
+      assert.fail();
+
+      return mockFirebase;
+    },
+    startAt: priority => {
+      assert.equal(priority, 1);
+
+      return mockFirebase;
+    },
+    on: (event, callback) => {
+      assert.equal(event, 'value');
+
+      const mockSnapshot = {
+        val: () => 'bar changed',
+      };
+
+      callback(mockSnapshot);
+    },
+  };
+
+  const mapPropsToSubscriptions = () => ({ bar: firebase => firebase.startAt(1) });
+  const WrappedComponent = connect(mapPropsToSubscriptions)('div');
+  const container = renderIntoDocument(<WrappedComponent firebase={mockFirebase} />);
+
+  assert.deepEqual(container.state.subscriptionsState, { bar: 'bar changed' });
+  assert.end();
+});
+
+test('Should unsubscribe when component unmounts', assert => {
+  const mockFirebase = {
+    child: path => {
+      assert.equal(path, 'baz');
+
+      return mockFirebase;
+    },
+    on: (event, callback) => {
+      assert.equal(event, 'value');
+
+      const mockSnapshot = {
+        val: () => 'baz changed',
+      };
+
+      callback(mockSnapshot);
+    },
+    off: event => {
+      assert.equal(event, 'value');
+    },
+  };
+
+  const mapPropsToSubscriptions = () => ({ baz: 'baz' });
+  const WrappedComponent = connect(mapPropsToSubscriptions)('div');
+  const container = renderIntoDocument(<WrappedComponent firebase={mockFirebase} />);
+
+  assert.deepEqual(container.state.subscriptionsState, { baz: 'baz changed' });
+
+  unmountComponentAtNode(findDOMNode(container).parentNode);
+
+  assert.end();
+});
+
+test('Should subscribe to nested paths');
+test('Should map firebase to props');
+test('Should keep connection to Firebase alive when specified and ignore later updates');
+test('Should update subscriptions when props change');
+test('Should not re-render if options.pure is true');
+test('Should re-render if options.pure is false');
+test('Should merge using mergeProps function');