Improve hidden fields list (#50)

Author: aivis

README.md

@@ -65,7 +65,7 @@ The following extra information will be collected:
 Additionally, you can specify which HTTP request field values should not be sent to Understand.io.
 By default, the following field values will be hidden: 
 ```
-UNDERSTAND_HIDDEN_REQUEST_FIELDS=password,access_token,secret_key,token,access_key
+UNDERSTAND_HIDDEN_REQUEST_FIELDS=password,password_confirmation,access_token,secret_key,token,access_key
 ```
 
 If you wish you can publish the configuration file and make desired adjustments. See [Advanced configuration](#advanced-configuration)

src/config/understand-laravel.php

@@ -70,5 +70,5 @@
      * Field names which values should not be sent to Understand.io
      * It applies to POST and GET request parameters
      */
-    'hidden_fields' => explode(',', env('UNDERSTAND_HIDDEN_REQUEST_FIELDS', 'password,access_token,secret_key,token,access_key')),
+    'hidden_fields' => explode(',', env('UNDERSTAND_HIDDEN_REQUEST_FIELDS', 'password,password_confirmation,access_token,secret_key,token,access_key')),
 ];

tests/FieldProviderTest.php

@@ -171,6 +171,17 @@ public function testPostRequestParameters()
         $this->assertEquals('[value hidden]', $postData['password']);
     }
 
+    public function testPasswordConfirmationField()
+    {
+        \Illuminate\Support\Facades\Route::post('/', function() {});
+
+        $this->call('POST', '/', ['password_confirmation' => 'a']);
+
+        $postData = $this->app['understand.fieldProvider']->getPostDataArray();
+
+        $this->assertEquals('[value hidden]', $postData['password_confirmation']);
+    }
+
     public function testJsonRequest()
     {
         if ( ! method_exists($this, 'json'))