Skip to content

Commit 3953bd4

Browse files
committed
#14 + small fix
1 parent 9609443 commit 3953bd4

File tree

3 files changed

+14
-26
lines changed

3 files changed

+14
-26
lines changed

dist/jquery.tagsinput-revisited.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

example.html

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -62,14 +62,14 @@
6262
$('#form-tags-1').tagsInput();
6363

6464
$('#form-tags-2').tagsInput({
65-
'onAddTag': function($el, value) {
66-
console.log('tag added');
65+
'onAddTag': function(input, value) {
66+
console.log('tag added', input, value);
6767
},
68-
'onRemoveTag': function($el, value) {
69-
console.log('tag removed');
68+
'onRemoveTag': function(input, value) {
69+
console.log('tag removed', input, value);
7070
},
71-
'onChange': function($el, $el2, value) {
72-
console.log('change triggered');
71+
'onChange': function(input, value) {
72+
console.log('change triggered', input, value);
7373
}
7474
});
7575

src/jquery.tagsinput-revisited.js

Lines changed: 7 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,13 @@
4747

4848
if (options.callback && callbacks[id] && callbacks[id]['onAddTag']) {
4949
var f = callbacks[id]['onAddTag'];
50-
f.call(this, value);
50+
f.call(this, this, value);
5151
}
5252

5353
if (callbacks[id] && callbacks[id]['onChange']) {
5454
var i = tagslist.length;
5555
var f = callbacks[id]['onChange'];
56-
f.call(this, $(this), tagslist[i - 1]);
56+
f.call(this, this, value);
5757
}
5858
});
5959

@@ -81,7 +81,7 @@
8181

8282
if (callbacks[id] && callbacks[id]['onRemoveTag']) {
8383
var f = callbacks[id]['onRemoveTag'];
84-
f.call(this, value);
84+
f.call(this, this, value);
8585
}
8686
});
8787

@@ -247,7 +247,7 @@
247247

248248
var tags = _splitIntoTags(event.data.delimiter, value);
249249

250-
if (tags.length > 0) {
250+
if (tags.length > 1) {
251251
for (var i = 0; i < tags.length; ++i) {
252252
$(event.data.real_input).addTag(tags[i], {
253253
focus: true,
@@ -302,7 +302,7 @@
302302

303303
if (callbacks[id] && callbacks[id]['onChange']) {
304304
var f = callbacks[id]['onChange'];
305-
f.call(obj, obj, tags[i]);
305+
f.call(obj, obj, tags);
306306
}
307307
};
308308

@@ -363,13 +363,7 @@
363363
if (value === '') return [];
364364

365365
if (typeof delimiter === 'string') {
366-
var tags = value.split(delimiter);
367-
368-
if (tags.length > 1) {
369-
return tags;
370-
} else {
371-
return [];
372-
}
366+
return value.split(delimiter);
373367
} else {
374368
var tmpDelimiter = '∞';
375369
var text = value;
@@ -378,13 +372,7 @@
378372
text = text.split(_delimiter).join(tmpDelimiter);
379373
});
380374

381-
var tags = text.split(tmpDelimiter);
382-
383-
if (tags.length > 1) {
384-
return tags;
385-
} else {
386-
return [];
387-
}
375+
return text.split(tmpDelimiter);
388376
}
389377

390378
return [];

0 commit comments

Comments
 (0)