Skip to content
This repository was archived by the owner on Dec 13, 2021. It is now read-only.

Commit f19fffc

Browse files
committed
Minor code amends
Spotted some small issues after the last few commits.
1 parent 2d887ba commit f19fffc

File tree

4 files changed

+3
-3
lines changed

4 files changed

+3
-3
lines changed

src/Our.Umbraco.Ditto/ComponentModel/Attributes/DittoCacheableAttribute.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ internal TOuputType GetCacheItem<TOuputType>(DittoCacheContext cacheContext, Fun
7070
throw new ApplicationException($"Expected a cache key builder of type {typeof(DittoCacheKeyBuilder)} but got {cacheKeyBuilderType}");
7171
}
7272

73+
// TODO: [LK:2018-01-18] Review this, a new instance is being created per call
7374
// Construct the cache key builder
7475
var builder = cacheKeyBuilderType.GetInstance<DittoCacheKeyBuilder>();
7576
var cacheKey = builder.BuildCacheKey(cacheContext);

src/Our.Umbraco.Ditto/ComponentModel/Processors/Contexts/DittoChainContext.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ internal ProcessorContextsCollection(IEnumerable<DittoProcessorContext> processo
4747
/// <summary>
4848
/// Adds a range of processor contexts to the collection chain.
4949
/// </summary>
50-
/// <param name="ctxs">An enumerable of processor contexts.</param>
50+
/// <param name="contexts">An enumerable of processor contexts.</param>
5151
public void AddRange(IEnumerable<DittoProcessorContext> contexts)
5252
{
5353
if (contexts == null)

src/Our.Umbraco.Ditto/Ditto.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
using System.Linq;
66
using System.Reflection;
77
using System.Web;
8-
using System.Web.Configuration;
9-
using Umbraco.Core;
108
using Umbraco.Core.Models;
119
using Umbraco.Web;
1210

tests/Our.Umbraco.Ditto.PerformanceTests/PublishedContentMapping.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ public void MapManually()
5858
Id = default(int), // this.content.Id,
5959
Name = default(string), // this.content.Name,
6060
Item = default(string), // this.content.GetProperty("item").Value.TryConvertTo<string>().Result
61+
Item = default(string) // this.content.GetProperty("item").Value.TryConvertTo<string>().Result
6162
};
6263
}
6364

0 commit comments

Comments
 (0)