Skip to content

Conversation

@JesmoDev
Copy link
Contributor

Having setAttribute in the constructor is no longer allowed and causes some components in New Backoffice to throw errors and not render.

This fixes it by setting the property instead.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@sonarqubecloud
Copy link

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-931.westeurope.azurestaticapps.net

@iOvergaard iOvergaard added the bug Something isn't working label Oct 11, 2024
@iOvergaard iOvergaard enabled auto-merge (squash) October 11, 2024 11:16
@iOvergaard iOvergaard disabled auto-merge October 11, 2024 11:17
@iOvergaard iOvergaard enabled auto-merge (squash) October 11, 2024 11:17
@iOvergaard iOvergaard merged commit a7ca074 into v1/contrib Oct 11, 2024
10 checks passed
@iOvergaard iOvergaard deleted the v1/bugfix/setAttribute-not-allowed-in-constructor branch October 11, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants