Skip to content

Conversation

@JesmoDev
Copy link
Contributor

Fixes: #748
Fixes combobox dropdown having 0 height in safari.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@JesmoDev JesmoDev changed the title fix height issue Bugfix: Combobox not working in Safari Oct 10, 2024
@JesmoDev JesmoDev requested a review from julczka October 10, 2024 10:40
@sonarqubecloud
Copy link

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-929.westeurope.azurestaticapps.net

Copy link
Contributor

@julczka julczka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Jesper! 💯

@julczka julczka merged commit 203487c into v1/contrib Oct 10, 2024
10 checks passed
@julczka julczka deleted the v1/bugfix/combobox-safari branch October 10, 2024 11:54
@iOvergaard iOvergaard added the bug Something isn't working label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UUI-Combobox does not display properly in Safari

4 participants