Skip to content

uui-loader-bar: Make loader-bar on uui-menu-item fade in #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2025
Merged

uui-loader-bar: Make loader-bar on uui-menu-item fade in #1219

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb8cffd
make loader-bar on uui-menu-item fade in
LanThuyNguyen Nov 4, 2025
45834e7
use animation css
LanThuyNguyen Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions packages/uui-menu-item/lib/uui-menu-item.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,9 +237,9 @@ export class UUIMenuItemElement extends SelectOnlyMixin(
: this._renderLabelAsButton()}

<slot id="actions-container" name="actions"></slot>
${this.loading
? html`<uui-loader-bar id="loader"></uui-loader-bar>`
: ''}
<uui-loader-bar
id="loader"
class=${this.loading ? 'visible' : ''}></uui-loader-bar>
</div>
${this.showChildren ? html`<slot></slot>` : ''}
`;
Expand Down Expand Up @@ -617,6 +617,16 @@ export class UUIMenuItemElement extends SelectOnlyMixin(
--uui-button-height: calc(var(--uui-size-base-unit) * 4);
margin-right: var(--uui-size-base-unit);
}

#loader {
opacity: 0;
transition: opacity 120ms ease-in 60ms;
pointer-events: none;
}

#loader.visible {
opacity: 1;
}
`,
];
}
Expand Down
Loading