Skip to content

Commit a88759c

Browse files
committed
test: use correct testing utils
1 parent 85d687a commit a88759c

File tree

1 file changed

+14
-11
lines changed

1 file changed

+14
-11
lines changed

packages/uui-popover-container/lib/uui-popover-container.test.ts

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,10 @@ describe('UUIPopoverContainerElement', () => {
4646
<dummy-shadow-dom>
4747
<div style="height: 200px; overflow: auto;" id="inner-scroll">
4848
<div style="height: 100px;"></div>
49-
<uui-button id="trigger-button" popovertarget="test-popover"
50-
>Open</uui-button
51-
>
49+
<uui-button
50+
id="trigger-button"
51+
popovertarget="test-popover"
52+
label="Open"></uui-button>
5253
<div style="height: 400px;"></div>
5354
</div>
5455
</dummy-shadow-dom>
@@ -72,8 +73,8 @@ describe('UUIPopoverContainerElement', () => {
7273
// Access the private scroll parents array for testing
7374
const scrollParents = popover._getScrollParents();
7475

75-
// Should find both scroll containers
76-
expect(scrollParents.length).to.be.greaterThan(0);
76+
// Should find all scroll containers
77+
expect(scrollParents.length).to.be.equal(3); // outer-scroll, inner-scroll, document.body
7778

7879
// Should include the document.body as the last element
7980
expect(scrollParents[scrollParents.length - 1]).to.equal(document.body);
@@ -86,9 +87,10 @@ describe('UUIPopoverContainerElement', () => {
8687
<div style="height: 300px; overflow: auto;" id="outer-scroll">
8788
<div style="position: absolute; top:0; left:0;" id="inner-scroll">
8889
<div style="height: 100px;"></div>
89-
<uui-button id="trigger-button" popovertarget="test-popover"
90-
>Open</uui-button
91-
>
90+
<uui-button
91+
id="trigger-button"
92+
popovertarget="test-popover"
93+
label="Open"></uui-button>
9294
<div style="height: 400px;"></div>
9395
</div>
9496
<div style="height: 500px;"></div>
@@ -122,9 +124,10 @@ describe('UUIPopoverContainerElement', () => {
122124
const testContainer = await fixture(html`
123125
<main>
124126
<div style="height: 300px; overflow: auto;" id="scroll-container">
125-
<uui-button id="trigger-button" popovertarget="test-popover"
126-
>Open</uui-button
127-
>
127+
<uui-button
128+
id="trigger-button"
129+
popovertarget="test-popover"
130+
label="Open"></uui-button>
128131
<div style="height: 400px;"></div>
129132
</div>
130133
<uui-popover-container id="test-popover" popover>

0 commit comments

Comments
 (0)