chore: eslint

Author: iOvergaard

eslint.config.mjs

@@ -31,6 +31,7 @@ export default [
       'vite.config.ts',
       'stories/',
       '**/.storybook/**',
+      '**/*.test.ts',
     ],
   },
 
@@ -50,10 +51,12 @@ export default [
       semi: ['warn', 'always'],
       'no-unused-vars': 'off', //Let '@typescript-eslint/no-unused-vars' catch the errors to allow unused function parameters (ex: in interfaces)
       'no-var': 'error',
+      '@typescript-eslint/no-unsafe-function-type': 'warn',
       '@typescript-eslint/explicit-module-boundary-types': 'off',
       '@typescript-eslint/no-non-null-assertion': 'off',
       '@typescript-eslint/no-explicit-any': 'off',
       '@typescript-eslint/no-inferrable-types': 'off',
+      '@typescript-eslint/no-empty-object-type': 'off',
       '@typescript-eslint/ban-ts-comment': 'off', //TODO: Remove (maybe)
       '@typescript-eslint/ban-types': 'off', //TODO: Remove (maybe)
       'lit/no-useless-template-literals': 'error',

packages/uui-base/lib/mixins/PopoverTargetMixin.ts

@@ -58,11 +58,13 @@ export const PopoverTargetMixin = <T extends Constructor<LitElement>>(
       );
       if (!popoverContainerElement) return;
 
-      this.#popoverIsOpen
-        ? // @ts-ignore - This is part of the new popover API, but typescript doesn't recognize it yet.
-          popoverContainerElement.hidePopover()
-        : // @ts-ignore - This is part of the new popover API, but typescript doesn't recognize it yet.
-          popoverContainerElement.showPopover();
+      if (this.#popoverIsOpen) {
+        // @ts-ignore - This is part of the new popover API, but typescript doesn't recognize it yet.
+        popoverContainerElement.hidePopover();
+      } else {
+        // @ts-ignore - This is part of the new popover API, but typescript doesn't recognize it yet.
+        popoverContainerElement.showPopover();
+      }
     };
 
     #popoverListener = (event: any) => {

packages/uui-base/lib/mixins/SelectableMixin.ts

@@ -153,8 +153,10 @@ export const SelectableMixin = <T extends Constructor<LitElement>>(
       if (!this.selectable) return;
       if (this.deselectable === false) {
         this.#select();
+      } else if (this.selected) {
+        this.#deselect();
       } else {
-        this.selected ? this.#deselect() : this.#select();
+        this.#select();
       }
     }
 

packages/uui-combobox-list/lib/uui-combobox-list.element.ts

@@ -210,12 +210,20 @@ export class UUIComboboxListElement extends LitElement {
     switch (e.key) {
       case 'ArrowUp':
         e.preventDefault();
-        e.ctrlKey ? this._moveIndex(-10) : this._moveIndex(-1);
+        if (e.ctrlKey) {
+          this._moveIndex(-10);
+        } else {
+          this._moveIndex(-1);
+        }
         break;
 
       case 'ArrowDown':
         e.preventDefault();
-        e.ctrlKey ? this._moveIndex(10) : this._moveIndex(1);
+        if (e.ctrlKey) {
+          this._moveIndex(10);
+        } else {
+          this._moveIndex(1);
+        }
 
         break;
 

packages/uui-popover/lib/uui-popover.element.ts

@@ -94,7 +94,11 @@ export class UUIPopoverElement extends LitElement {
   set open(newValue) {
     const oldValue = this._open;
     this._open = newValue;
-    newValue ? this._openPopover() : this._closePopover();
+    if (newValue) {
+      this._openPopover();
+    } else {
+      this._closePopover();
+    }
     this.requestUpdate('open', oldValue);
   }
 

packages/uui-table/lib/uui-table-advanced-example.ts

@@ -6,6 +6,7 @@ import '@umbraco-ui/uui-checkbox/lib';
 import '@umbraco-ui/uui-icon/lib';
 import '@umbraco-ui/uui-progress-bar/lib';
 import '@umbraco-ui/uui-tag/lib';
+import '@umbraco-ui/uui-symbol-sort/lib';
 
 import { UUITextStyles } from '@umbraco-ui/uui-css/lib';
 import { css, html, LitElement } from 'lit';
@@ -15,7 +16,7 @@ import { defineElement } from '@umbraco-ui/uui-base/lib/registration';
 
 interface TableColumn {
   name: string;
-  sort: Function;
+  sort: (items: Array<TableItem>, desc: boolean) => Array<TableItem>;
 }
 
 interface TableItem {
@@ -224,9 +225,9 @@ export class UUITableWithSelectionExampleElement extends LitElement {
       <uui-table-cell>${item.signUpDate}</uui-table-cell>
       <uui-table-cell>${item.email}</uui-table-cell>
       <uui-table-cell>
-        <uui-tag color="${item.newsletter ? 'positive' : 'secondary'}" size="s"
-          >${item.newsletter ? 'Yes' : 'No'}</uui-tag
-        >
+        <uui-tag color="${item.newsletter ? 'positive' : 'danger'}">
+          ${item.newsletter ? 'Yes' : 'No'}
+        </uui-tag>
       </uui-table-cell>
     </uui-table-row>`;
   };

packages/uui-tabs/lib/uui-tab-group.element.ts

@@ -145,9 +145,11 @@ export class UUITabGroupElement extends LitElement {
         el => el.active && el !== linkedElement,
       );
 
-      hasActiveHidden
-        ? this._moreButtonElement.classList.add('active-inside')
-        : this._moreButtonElement.classList.remove('active-inside');
+      if (hasActiveHidden) {
+        this._moreButtonElement.classList.add('active-inside');
+      } else {
+        this._moreButtonElement.classList.remove('active-inside');
+      }
     }
   };
 
@@ -250,9 +252,11 @@ export class UUITabGroupElement extends LitElement {
       this._moreButtonElement.style.display = '';
     }
 
-    hasActiveTabInDropdown
-      ? this._moreButtonElement.classList.add('active-inside')
-      : this._moreButtonElement.classList.remove('active-inside');
+    if (hasActiveTabInDropdown) {
+      this._moreButtonElement.classList.add('active-inside');
+    } else {
+      this._moreButtonElement.classList.remove('active-inside');
+    }
 
     this.requestUpdate();
   }