Merge pull request #2288 from umbraco/v14/bugfix/rollback-permissions

Bugfix: Enforce Rollback permissions

Author: nielslyngsoe

src/packages/core/icon-registry/icon-dictionary.json

@@ -1096,6 +1096,10 @@
 			"name": "icon-help",
 			"file": "life-buoy.svg"
 		},
+		{
+			"name": "icon-history",
+			"file": "history.svg"
+		},
 		{
 			"name": "icon-home",
 			"file": "house.svg"

src/packages/core/icon-registry/icons.ts

@@ -879,6 +879,10 @@ name: "icon-help",
 
 path: () => import("./icons/icon-help.js"),
 },{
+name: "icon-history",
+
+path: () => import("./icons/icon-history.js"),
+},{
 name: "icon-home",
 
 path: () => import("./icons/icon-home.js"),

src/packages/core/icon-registry/icons/icon-history.ts

@@ -0,0 +1,16 @@
+export default `<!-- @license lucide-static v0.424.0 - ISC -->
+<svg
+  class="lucide lucide-history"
+  xmlns="http://www.w3.org/2000/svg"
+  viewBox="0 0 24 24"
+  fill="none"
+  stroke="currentColor"
+  stroke-width="1.75"
+  stroke-linecap="round"
+  stroke-linejoin="round"
+>
+  <path d="M3 12a9 9 0 1 0 9-9 9.75 9.75 0 0 0-6.74 2.74L3 8" />
+  <path d="M3 3v5h5" />
+  <path d="M12 7v5l4 2" />
+</svg>
+`;

src/packages/documents/documents/manifests.ts

@@ -8,6 +8,7 @@ import { manifests as pickerManifests } from './picker/manifests.js';
 import { manifests as propertyEditorManifests } from './property-editors/manifests.js';
 import { manifests as recycleBinManifests } from './recycle-bin/manifests.js';
 import { manifests as repositoryManifests } from './repository/manifests.js';
+import { manifests as rollbackManifests } from './rollback/manifests.js';
 import { manifests as searchProviderManifests } from './search/manifests.js';
 import { manifests as trackedReferenceManifests } from './reference/manifests.js';
 import { manifests as treeManifests } from './tree/manifests.js';
@@ -27,6 +28,7 @@ export const manifests: Array<ManifestTypes | UmbBackofficeManifestKind> = [
 	...propertyEditorManifests,
 	...recycleBinManifests,
 	...repositoryManifests,
+	...rollbackManifests,
 	...searchProviderManifests,
 	...trackedReferenceManifests,
 	...treeManifests,

src/packages/documents/documents/modals/manifests.ts

@@ -1,19 +1,12 @@
 import type { ManifestModal, ManifestTypes } from '@umbraco-cms/backoffice/extension-registry';
 
-export const UMB_ROLLBACK_MODAL_ALIAS = 'Umb.Modal.Rollback';
 export const UMB_DOCUMENT_SAVE_MODAL_ALIAS = 'Umb.Modal.DocumentSave';
 export const UMB_DOCUMENT_PUBLISH_MODAL_ALIAS = 'Umb.Modal.DocumentPublish';
 export const UMB_DOCUMENT_UNPUBLISH_MODAL_ALIAS = 'Umb.Modal.DocumentUnpublish';
 export const UMB_DOCUMENT_SCHEDULE_MODAL_ALIAS = 'Umb.Modal.DocumentSchedule';
 export const UMB_DOCUMENT_PUBLISH_WITH_DESCENDANTS_MODAL_ALIAS = 'Umb.Modal.DocumentPublishWithDescendants';
 
 const modals: Array<ManifestModal> = [
-	{
-		type: 'modal',
-		alias: UMB_ROLLBACK_MODAL_ALIAS,
-		name: 'Rollback Modal',
-		js: () => import('./rollback/rollback-modal.element.js'),
-	},
 	{
 		type: 'modal',
 		alias: UMB_DOCUMENT_SAVE_MODAL_ALIAS,

src/packages/documents/documents/rollback/entity-action/manifests.ts

@@ -0,0 +1,36 @@
+import { UMB_DOCUMENT_ENTITY_TYPE } from '../../entity.js';
+import { UMB_USER_PERMISSION_DOCUMENT_ROLLBACK } from '../../user-permissions/index.js';
+import { UMB_DOCUMENT_WORKSPACE_ALIAS } from '../../workspace/index.js';
+import { UMB_ENTITY_IS_NOT_TRASHED_CONDITION_ALIAS } from '@umbraco-cms/backoffice/recycle-bin';
+import type { ManifestTypes } from '@umbraco-cms/backoffice/extension-registry';
+
+export const manifests: Array<ManifestTypes> = [
+	{
+		type: 'entityAction',
+		kind: 'default',
+		alias: 'Umb.EntityAction.Document.Rollback',
+		name: 'Rollback Document Entity Action',
+		weight: 500,
+		api: () => import('./rollback.action.js'),
+		forEntityTypes: [UMB_DOCUMENT_ENTITY_TYPE],
+		meta: {
+			icon: 'icon-history',
+			label: '#actions_rollback',
+		},
+		conditions: [
+			{
+				alias: 'Umb.Condition.UserPermission.Document',
+				allOf: [UMB_USER_PERMISSION_DOCUMENT_ROLLBACK],
+			},
+			{
+				alias: UMB_ENTITY_IS_NOT_TRASHED_CONDITION_ALIAS,
+			},
+			/* Currently the rollback is tightly coupled to the workspace contexts so we only allow it to show up
+			 In the document workspace. */
+			{
+				alias: 'Umb.Condition.WorkspaceAlias',
+				match: UMB_DOCUMENT_WORKSPACE_ALIAS,
+			},
+		],
+	},
+];

src/packages/documents/documents/rollback/entity-action/rollback.action.ts

@@ -0,0 +1,22 @@
+import { UMB_ROLLBACK_MODAL } from '../modal/rollback-modal.token.js';
+import { UmbEntityActionBase } from '@umbraco-cms/backoffice/entity-action';
+import { UMB_MODAL_MANAGER_CONTEXT } from '@umbraco-cms/backoffice/modal';
+import { UMB_NOTIFICATION_CONTEXT } from '@umbraco-cms/backoffice/notification';
+import { UmbLocalizationController } from '@umbraco-cms/backoffice/localization-api';
+
+export class UmbRollbackDocumentEntityAction extends UmbEntityActionBase<never> {
+	#localize = new UmbLocalizationController(this);
+
+	override async execute() {
+		const modalManagerContext = await this.getContext(UMB_MODAL_MANAGER_CONTEXT);
+		const modalContext = modalManagerContext.open(this, UMB_ROLLBACK_MODAL, {});
+
+		await modalContext.onSubmit();
+		const notificationContext = await this.getContext(UMB_NOTIFICATION_CONTEXT);
+		notificationContext.peek('positive', {
+			data: { message: this.#localize.term('rollback_documentRolledBack') },
+		});
+	}
+}
+
+export { UmbRollbackDocumentEntityAction as api };

src/packages/documents/documents/rollback/index.ts

@@ -0,0 +1,2 @@
+export * from './modal/index.js';
+export * from './repository/index.js';

src/packages/documents/documents/rollback/manifests.ts

@@ -0,0 +1,6 @@
+import { manifests as entityActionManifests } from './entity-action/manifests.js';
+import { manifests as modalManifests } from './modal/manifests.js';
+import { manifests as repositoryManifests } from './repository/manifests.js';
+import type { ManifestTypes } from '@umbraco-cms/backoffice/extension-registry';
+
+export const manifests: Array<ManifestTypes> = [...entityActionManifests, ...modalManifests, ...repositoryManifests];

src/packages/documents/documents/rollback/modal/constants.ts

@@ -0,0 +1 @@
+export const UMB_ROLLBACK_MODAL_ALIAS = 'Umb.Modal.Rollback';