remove property to prevent too much re-rendering

nielslyngsoe · nielslyngsoe · commit 89682906f8ea · 2024-06-26T12:45:47.000+02:00
diff --git a/src/packages/ufm/components/ufm-render/ufm-render.element.ts b/src/packages/ufm/components/ufm-render/ufm-render.element.ts
@@ -51,7 +51,6 @@ export class UmbUfmRenderElement extends UmbLitElement {
 	@property()
 	markdown?: string;
 
-	@property({ attribute: false })
 	public set value(value: string | unknown | undefined) {
 		this.#context.setValue(value);
 	}
@@ -83,6 +82,7 @@ export class UmbUfmRenderElement extends UmbLitElement {
 	}
 
 	override render() {
+		console.log("re-render?", this)
 		return until(this.#renderMarkdown());
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,6 @@ export class UmbUfmRenderElement extends UmbLitElement {`
`51`	`51`	`@property()`
`52`	`52`	`markdown?: string;`
`53`	`53`
`54`		`- @property({ attribute: false })`
`55`	`54`	`public set value(value: string \| unknown \| undefined) {`
`56`	`55`	`this.#context.setValue(value);`
`57`	`56`	`}`
`@@ -83,6 +82,7 @@ export class UmbUfmRenderElement extends UmbLitElement {`
`83`	`82`	`}`
`84`	`83`
`85`	`84`	`override render() {`
	`85`	`+ console.log("re-render?", this)`
`86`	`86`	`return until(this.#renderMarkdown());`
`87`	`87`	`}`
`88`	`88`