Media Picker Fixed folder navigation when returning from an empty folder (closes #20975) #20987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyButland
changed the title
Copilot finished reviewing on behalf of
AndyButland
November 28, 2025 09:17
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression in the media picker where navigating from an empty folder back to the root caused an error. The issue occurred because the API returns a pageSize of 0 for empty folders, which was being blindly assigned to the pagination options, breaking subsequent navigation.
Key changes:
- Added a guard condition to prevent updating pageSize when the value is 0 or less
...Umbraco.Web.UI.Client/src/views/common/infiniteeditors/mediapicker/mediapicker.controller.js
Show resolved
Hide resolved
leekelleher
approved these changes
Dec 1, 2025
Member
leekelleher
left a comment
leekelleher
left a comment
There was a problem hiding this comment.
Tested out, works as described. 🚀
leekelleher
deleted the
v13/bugfix/handle-empty-folder-in-media-picker
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Fixes: #20975
Description
This PR fixes the regression described in the linked issue.
Testing
To replicate the original issue:
With this PR in place you should navigate back to the root without error.