Upgrade screen shows wrong "detected" version

[OwainJ]

Which Umbraco version are you using?

17.0.0

Bug summary

The upgrade screen appears to show the wrong "detected version", where it shows the currently installed version, rather than the version detected from the database's Umbraco.Core.Upgrader.State+Umbraco.Core value.

Specifics

No response

Steps to reproduce

• Create a v13 project using this script:
  • Package Script Writer: v13.12.0 script
• Run it once to generate the database
• Create a v17 project using this script:
  • Package Script Writer: v17.0.0 script
• Point the v17 project at the v13 database
• Run the project and observe the "Upgrading Umbraco" screen

Expected result / actual result

Expected Result
I would've expected it to say:

Detected current version 13.5.0 ({CC47C751-A81B-489A-A2BC-0240245DB687}), which needs to be upgraded to 17.0.0+da502e0 ({1C38D589-26BB-4A46-9ABE-E4A0DF548A87}). 

As the Umbraco migration step GUID maps to the v13.5.0 update:

Umbraco-CMS/src/Umbraco.Infrastructure/Migrations/Upgrade/UmbracoPlan.cs

Line 66 in f44e932

To<V_13_5_0.ChangeRedirectUrlToNvarcharMax>("{CC47C751-A81B-489A-A2BC-0240245DB687}");

Actual Result
But it actually just says the current installed version, even though that does not match the detected migration plan GUID.

Detected current version 17.0.0 ({CC47C751-A81B-489A-A2BC-0240245DB687}), which needs to be upgraded to 17.0.0+da502e0 ({1C38D589-26BB-4A46-9ABE-E4A0DF548A87}). 

Thoughts
I realise that not every minor/patch version has a matching migration plan step, so in my case, my database was actually from a v13.10.1 site, so maybe it would be better if it just stated the detected major version?

E.g:

Detected current version 13 ({CC47C751-A81B-489A-A2BC-0240245DB687}), which needs to be upgraded to 17.0.0+da502e0 ({1C38D589-26BB-4A46-9ABE-E4A0DF548A87}).

I just think that the current wording could be confusing to those who don't understand how Umbraco's migration plans work, or what the GUIDs shown actually mean.

Edit:
I just realised that this also causes the "View report" button to be useless, as it simply opens up a comparison page where it attempts to compare v17 to v17:

[github-actions]

Hi there @OwainJ!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[Zeegaan]

I guess the wording is different in 13! But the view report button apparently hasn't worked in a long time, it always just compares with the first release of a major version (EG 12.0, 13.0 etc), here is a screenshot I took from my v13 site with a v12 database:
But I agree something should be done about this 😁

Even when I'm coming from a V12 database, the button just takes me to a change view from 13.0 -> 13.12