Skip to content

Bump org.jsoup:jsoup from 1.15.3 to 1.17.2 #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bump org.jsoup:jsoup from 1.15.3 to 1.17.2 #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
583f7a3
Bump org.jsoup:jsoup from 1.15.3 to 1.17.2
dependabot[bot] Mar 26, 2024
39783ad
Fix test failures due to pretty printing changes in jsoup
ulfsauer0815 Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ dependencies {
implementation("org.jetbrains.kotlin:kotlin-stdlib-jdk8")

implementation("org.assertj:assertj-core:3.25.3")
implementation("org.jsoup:jsoup:1.15.3")
implementation("org.jsoup:jsoup:1.17.2")

testImplementation("org.jetbrains.kotlin:kotlin-test")
testImplementation("org.jetbrains.kotlin:kotlin-test-junit")
Expand Down
9 changes: 7 additions & 2 deletions src/test/kotlin/io/github/ulfs/assertj/jsoup/DocumentAssertElementContainsHtmlTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ class DocumentAssertElementContainsHtmlTest {
fun `should pass if element contains html`() {
// given
val document: Document = JsoupUtils.parse("""<div class="class">html<br>text</div>""")
.outputSettings(Document.OutputSettings().prettyPrint(false))

// when
assertThat(document, true) {
Expand All @@ -64,6 +65,7 @@ class DocumentAssertElementContainsHtmlTest {
fun `should pass if element contains html in different form`() {
// given
val document: Document = JsoupUtils.parse("""<div class="class">html<br/>text</div>""")
.outputSettings(Document.OutputSettings().prettyPrint(false))

// when
assertThat(document, true) {
Expand All @@ -77,7 +79,8 @@ class DocumentAssertElementContainsHtmlTest {
@Test
fun `should pass if element contains nested html`() {
// given
val document: Document = JsoupUtils.parse("""<div class="class"><p><span>text</span><span>html</span></p></div>""")
val document: Document =
JsoupUtils.parse("""<div class="class"><p><span>text</span><span>html</span></p></div>""")

// when
assertThat(document, true) {
Expand All @@ -91,7 +94,8 @@ class DocumentAssertElementContainsHtmlTest {
@Test
fun `should pass if element contains complex html`() {
// given
val document: Document = JsoupUtils.parse("""<div class="class"><span><b>h</b>t<strong>m</strong>l</span></div>""")
val document: Document =
JsoupUtils.parse("""<div class="class"><span><b>h</b>t<strong>m</strong>l</span></div>""")

// when
assertThat(document, true) {
Expand All @@ -106,6 +110,7 @@ class DocumentAssertElementContainsHtmlTest {
fun `should pass if element text is the entire html`() {
// given
val document: Document = JsoupUtils.parse("""<div class="class">html<br>text</div>""")
.outputSettings(Document.OutputSettings().prettyPrint(false))

// when / then
assertThat(document, true) {
Expand Down
16 changes: 10 additions & 6 deletions src/test/kotlin/io/github/ulfs/assertj/jsoup/DocumentAssertElementHasHtmlTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ class DocumentAssertElementHasHtmlTest {
fun `should pass if element has html`() {
// given
val document: Document = JsoupUtils.parse("""<div class="class">text<br>html</div>""")
.outputSettings(Document.OutputSettings().prettyPrint(false))

// when
assertThat(document, true) {
Expand All @@ -102,6 +103,7 @@ class DocumentAssertElementHasHtmlTest {
fun `should pass if element has html in inner node`() {
// given
val document: Document = JsoupUtils.parse("""<div class="class"><span>text<br>html</span></div>""")
.outputSettings(Document.OutputSettings().prettyPrint(false))

// when
assertThat(document, true) {
Expand Down Expand Up @@ -130,6 +132,7 @@ class DocumentAssertElementHasHtmlTest {
fun `should fail if element contains substring`() {
// given
val document: Document = JsoupUtils.parse("""<div class="class">text<br>html</div>""")
.outputSettings(Document.OutputSettings().prettyPrint(false))

// when / then
assertThatThrownBy {
Expand All @@ -156,6 +159,7 @@ class DocumentAssertElementHasHtmlTest {
fun `should fail if element contains different html`() {
// given
val document: Document = JsoupUtils.parse("""<div class="class">different<br>html</div>""")
.outputSettings(Document.OutputSettings().prettyPrint(false))

// when / then
assertThatThrownBy {
Expand Down Expand Up @@ -188,6 +192,7 @@ class DocumentAssertElementHasHtmlTest {
<div class="class">html<br>text</div>
""".trimIndent()
)
.outputSettings(Document.OutputSettings().prettyPrint(false))

// when
assertThat(document, true) {
Expand All @@ -208,6 +213,7 @@ class DocumentAssertElementHasHtmlTest {
<div class="class">html<br>text</div>
""".trimIndent()
)
.outputSettings(Document.OutputSettings().prettyPrint(false))

// when / then
assertThatThrownBy {
Expand Down Expand Up @@ -239,6 +245,7 @@ class DocumentAssertElementHasHtmlTest {
<div class="class">really<br>long</div>
""".trimIndent()
)
.outputSettings(Document.OutputSettings().prettyPrint(false))

// when / then
assertThatThrownBy {
Expand All @@ -256,12 +263,8 @@ class DocumentAssertElementHasHtmlTest {
to be html
[html<br>text]
in list
<div class="class">
this<br>is
</div>
<div class="class">
really<br>long
</div>
<div class="class">this<br>is</div>
<div class="class">really<br>long</div>
""".trimIndent()
)
}
Expand All @@ -277,6 +280,7 @@ class DocumentAssertElementHasHtmlTest {
<div class="class">but<br>more</div>
""".trimIndent()
)
.outputSettings(Document.OutputSettings().prettyPrint(false))

// when / then
assertThat(document, true) {
Expand Down
2 changes: 2 additions & 0 deletions src/test/kotlin/io/github/ulfs/assertj/jsoup/DocumentAssertElementMatchesHtmlTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ class DocumentAssertElementMatchesHtmlTest {
fun `should pass if element html matches`() {
// given
val document: Document = JsoupUtils.parse("""<div class="class">text<br>html</div>""")
.outputSettings(Document.OutputSettings().prettyPrint(false))

// when
assertThat(document, true) {
Expand All @@ -64,6 +65,7 @@ class DocumentAssertElementMatchesHtmlTest {
fun `should pass if element text matches in inner node`() {
// given
val document: Document = JsoupUtils.parse("""<div class="class"><span>text<br>html</span></div>""")
.outputSettings(Document.OutputSettings().prettyPrint(false))

// when
assertThat(document, true) {
Expand Down