Improve test coverage

Author: Steve Rhoades

projects/ng-dynamic-forms/core/src/lib/service/dynamic-form-data.service.spec.ts

@@ -12,6 +12,7 @@ import {
 import {Observable, of} from 'rxjs';
 import {Injectable} from '@angular/core';
 import {DynamicInputModel} from '../model/input/dynamic-input.model';
+import {DynamicFormGroupModel} from '../model/form-group/dynamic-form-group.model';
 
 @Injectable()
 class TestProvider implements DynamicFormControlListDataProvider, DynamicFormControlOptionDataProvider {
@@ -69,8 +70,8 @@ describe("DynamicFormDataService test suite", () => {
         service: TestProvider
       }
     }),
-    invalidProvider: DynamicInputModel = new DynamicInputModel({
-      id: "testInput3",
+    invalidListProvider: DynamicInputModel = new DynamicInputModel({
+      id: "invalidListProvider",
       list: ['item-1', 'item-2', 'item-3'],
       value: "item-1",
       dataProvider: {
@@ -79,7 +80,54 @@ describe("DynamicFormDataService test suite", () => {
         },
         service: InvalidTestProvider,
       }
-    })
+    }),
+    invalidOptionProvider: DynamicSelectModel<any> = new DynamicSelectModel({
+      id: "invalidOptionProvider",
+      options: [{value: "option-1"}, {value: "option-2"}, {value: "option-3"}],
+      value: "option-1",
+      dataProvider: {
+        relation: {
+          id: 'testInput'
+        },
+        service: InvalidTestProvider,
+      }
+    }),
+    referenceInvalidControl: DynamicInputModel = new DynamicInputModel({
+      id: "referenceInvalidControl",
+      list: ['item-1', 'item-2', 'item-3'],
+      value: "item-1",
+      dataProvider: {
+        relation: {
+          id: 'not-an-id'
+        },
+        service: TestProvider,
+      }
+    }),
+    groupModel = new DynamicFormGroupModel({
+      id: 'test',
+      group: [
+        new DynamicRadioGroupModel({
+          id: "testRootRadioGroup",
+          options: [{value: "option-1"}, {value: "option-2"}, {value: "option-3"}],
+          value: "option-1",
+          dataProvider: {
+            relation: {
+              id: 'testInput'
+            },
+            service: TestProvider
+          }
+        }),
+      ]
+    }),
+    groupInputTest = new DynamicInputModel({
+    id: "testInput",
+    dataProvider: {
+      relation: {
+        rootPath: 'test.testRootRadioGroup'
+      },
+      service: TestProvider,
+    }
+  })
   ;
 
   beforeEach(() => {
@@ -100,7 +148,9 @@ describe("DynamicFormDataService test suite", () => {
         model,
         select,
         radio,
-        invalidProvider
+        invalidListProvider,
+        invalidOptionProvider,
+        groupModel
       ]);
     }));
 
@@ -138,12 +188,33 @@ describe("DynamicFormDataService test suite", () => {
     radio.options$.subscribe((options) =>  expect(options[0].value).toBe('test'));
   }));
 
-  it("should not fail with invalid provider but receive warning.", fakeAsync(() => {
+  it("should not fail with invalid provider but receive warning with missing list data provider.", fakeAsync(() => {
     const triggerControl = group.get('testInput');
 
-    service.connectDynamicFormControls(invalidProvider, group);
+    service.connectDynamicFormControls(invalidListProvider, group);
     triggerControl.setValue('newVal');
     tick(401);
-    invalidProvider.list$.subscribe((list) =>  expect(list[0]).toBe('item-1'));
+    invalidListProvider.list$.subscribe((list) =>  expect(list[0]).toBe('item-1'));
   }));
+
+  it("should not fail with invalid provider but receive warning with missing options data provider.", fakeAsync(() => {
+    const triggerControl = group.get('testInput');
+
+    service.connectDynamicFormControls(invalidOptionProvider, group);
+    triggerControl.setValue('newVal');
+    tick(401);
+    radio.options$.subscribe((options) =>  expect(options[0].value).toBe('option-1'));
+  }));
+
+  it('should show warning with invalid relatedform control', () => {
+    const relatedFormControl = service.getRelatedFormControl(referenceInvalidControl, group);
+    expect(relatedFormControl).toBe(null);
+  });
+
+  it('should get related form control from rootPath', () => {
+    const compareControl = group.root.get('test.testRootRadioGroup');
+    const relatedFormControl = service.getRelatedFormControl(groupInputTest, group);
+
+    expect(relatedFormControl).toBe(compareControl);
+  });
 });