Switch local copy operations to use COPY instead of ADD as recommended in

docker docs and pointed out by hadolint.

Author: jonasbardino

Dockerfile.rocky8

@@ -1718,14 +1718,15 @@ ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini /tini
 RUN chmod +x /tini
 ENTRYPOINT ["/tini", "--"]
 
-ADD docker-entry.sh /app/docker-entry.sh
-ADD migrid-httpd.env /app/migrid-httpd.env
-ADD migrid-httpd-init.sh /app/migrid-httpd-init.sh
-ADD apache-init-helper /etc/init.d/apache-minimal
+# NOTE: it's recommended to use COPY over ADD except when URL/unpack is needed
+COPY docker-entry.sh /app/docker-entry.sh
+COPY migrid-httpd.env /app/migrid-httpd.env
+COPY migrid-httpd-init.sh /app/migrid-httpd-init.sh
+COPY apache-init-helper /etc/init.d/apache-minimal
 # NOTE: inherit explicit LANG set above for apache and migrid services
 RUN sed "s/#LANG=.*/LANG=${LANG}/g" /app/migrid-httpd-init.sh > /etc/sysconfig/apache-minimal
 RUN grep LANG /etc/sysconfig/apache-minimal > /etc/sysconfig/migrid
-ADD rsyslog-init-helper /etc/init.d/rsyslog-minimal
+COPY rsyslog-init-helper /etc/init.d/rsyslog-minimal
 RUN chown $USER:$GROUP /app/docker-entry.sh \
     && chmod +x /app/docker-entry.sh
 

Dockerfile.rocky9

@@ -1605,14 +1605,15 @@ ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini /tini
 RUN chmod +x /tini
 ENTRYPOINT ["/tini", "--"]
 
-ADD docker-entry.sh /app/docker-entry.sh
-ADD migrid-httpd.env /app/migrid-httpd.env
-ADD migrid-httpd-init.sh /app/migrid-httpd-init.sh
-ADD apache-init-helper /etc/init.d/apache-minimal
+# NOTE: it's recommended to use COPY over ADD except when URL/unpack is needed
+COPY docker-entry.sh /app/docker-entry.sh
+COPY migrid-httpd.env /app/migrid-httpd.env
+COPY migrid-httpd-init.sh /app/migrid-httpd-init.sh
+COPY apache-init-helper /etc/init.d/apache-minimal
 # NOTE: inherit explicit LANG set above for apache and migrid services
 RUN sed "s/#LANG=.*/LANG=${LANG}/g" /app/migrid-httpd-init.sh > /etc/sysconfig/apache-minimal
 RUN grep LANG /etc/sysconfig/apache-minimal > /etc/sysconfig/migrid
-ADD rsyslog-init-helper /etc/init.d/rsyslog-minimal
+COPY rsyslog-init-helper /etc/init.d/rsyslog-minimal
 RUN chown $USER:$GROUP /app/docker-entry.sh \
     && chmod +x /app/docker-entry.sh