Skip to content

Conversation

@vungle-zhongliangong
Copy link

@vungle-zhongliangong vungle-zhongliangong commented Dec 2, 2025

To keep the module consistent - the module should be the same as the current repo.

Relative imports would reduce the changes needed when packages are moved over, but this is not officially supported by golang.

Summary by CodeRabbit

  • New Features

    • Added support for OpenID, profile, and email scopes in Protected Resource Metadata.
  • Chores

    • Updated module namespace from tuannvm to Vungle across the codebase.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Zhong Liang Ong <zong@liftoff.io>
Signed-off-by: Zhong Liang Ong <zong@liftoff.io>
@coderabbitai
Copy link

coderabbitai bot commented Dec 2, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This PR performs a module namespace migration, updating the codebase from github.com/tuannvm/oauth-mcp-proxy to github.com/Vungle/oauth-mcp-proxy across go.mod and all import statements. Additionally, scopes support is added to the Protected Resource Metadata response.

Changes

Cohort / File(s) Summary
Module declaration
go.mod
Updated module path from tuannvm to Vungle namespace
Core package imports
cache.go, config.go, middleware.go, oauth.go
Updated provider import paths to Vungle namespace
Provider subpackage
mark3labs/oauth.go, mark3labs/middleware.go, mcp/oauth.go
Updated oauth-mcp-proxy imports to Vungle namespace
Test files
context_propagation_test.go, integration_test.go
Updated provider import paths to Vungle namespace
Example files
examples/mark3labs/*/main.go, examples/official/*/main.go
Updated oauth-mcp-proxy and subpackage imports to Vungle namespace
Metadata enhancement
metadata.go
Added scopes_supported array with values ["openid", "profile", "email"] to Protected Resource Metadata response

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

This PR consists primarily of homogeneous import path updates across multiple files following a consistent pattern, plus a trivial metadata field addition. While the number of files is notable, the repetitive nature of the changes reduces review complexity.

  • Attention areas: Verify all import paths are consistently updated across the codebase; confirm metadata.go field addition aligns with OAuth scope expectations.

Possibly related PRs

No related PRs with strong code-level connections were identified.

Poem

🐰 From tuannvm to Vungle we hop,
A namespace migration, never to stop,
Import paths dance in rhythmic delight,
With scopes now shining, everything's right,
Our proxy grows grand in its new home tonight! 🎉

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2237925 and eea857e.

📒 Files selected for processing (15)
  • cache.go (1 hunks)
  • config.go (1 hunks)
  • context_propagation_test.go (1 hunks)
  • examples/mark3labs/advanced/main.go (1 hunks)
  • examples/mark3labs/simple/main.go (1 hunks)
  • examples/official/advanced/main.go (1 hunks)
  • examples/official/simple/main.go (1 hunks)
  • go.mod (1 hunks)
  • integration_test.go (1 hunks)
  • mark3labs/middleware.go (1 hunks)
  • mark3labs/oauth.go (1 hunks)
  • mcp/oauth.go (1 hunks)
  • metadata.go (1 hunks)
  • middleware.go (1 hunks)
  • oauth.go (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant