Skip to content

Commit bd64c36

Browse files
authored
Set OTEL export to default to false, fixing flag-overwriting bug (#589)
1 parent 3bb761c commit bd64c36

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

api/gorch/v1alpha1/guardrailsorchestrator_types.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,11 +86,9 @@ type OTelExporter struct {
8686
OTLPMetricsEndpoint string `json:"otlpMetricsEndpoint,omitempty"`
8787
// Specifies whether to enable tracing data export
8888
// +optional
89-
// +kubebuilder:default=true
9089
EnableTraces bool `json:"enableTraces,omitempty"`
9190
// Specifies whether to enable metrics data export
9291
// +optional
93-
// +kubebuilder:default=true
9492
EnableMetrics bool `json:"enableMetrics,omitempty"`
9593
}
9694

api/gorch/v1alpha1/zz_generated.deepcopy.go

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/bases/trustyai.opendatahub.io_guardrailsorchestrators.yaml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,8 @@ spec:
5858
- inferenceServiceToGuardrail
5959
type: object
6060
customDetectorsConfig:
61-
description: Name of configmap containing user-defined Python detectors
61+
description: Name of configmap containing user-defined Python detectors.
62+
This is only used if EnableBuiltInDetectors is true
6263
type: string
6364
enableBuiltInDetectors:
6465
description: Boolean flag to enable/disable built-in detectors
@@ -83,11 +84,9 @@ spec:
8384
the OTLP exporter
8485
properties:
8586
enableMetrics:
86-
default: true
8787
description: Specifies whether to enable metrics data export
8888
type: boolean
8989
enableTraces:
90-
default: true
9190
description: Specifies whether to enable tracing data export
9291
type: boolean
9392
otlpMetricsEndpoint:

0 commit comments

Comments
 (0)