Skip to content

Conversation

@marcelschurer
Copy link
Contributor

This PR changes the return type of the vtk2trixi function from InitialCondition to a NamedTuple and adds several other important quantities.

@LasNikas LasNikas changed the title Update vtk2trixi to return NamedTuple instead of InitialCondition Revise vtk2trixi so that it returns a NamedTuple instead of an InitialCondition Oct 20, 2025
@marcelschurer marcelschurer marked this pull request as ready for review October 21, 2025 12:31
@svchb
Copy link
Collaborator

svchb commented Oct 23, 2025

@LasNikas Didn't you have code somewhere to do a restart via vtk2trixi? If yes it still needs to be updated.

@LasNikas
Copy link
Collaborator

@LasNikas Didn't you have code somewhere to do a restart via vtk2trixi? If yes it still needs to be updated.

@svchb No, but it is still a breaking change because the return type has changed.

@LasNikas LasNikas added this to the 0.5 milestone Oct 29, 2025
@LasNikas LasNikas added the breaking changes This change will break the public API and requires a new major release label Oct 29, 2025
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 92.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.59%. Comparing base (32679eb) to head (0b22696).

Files with missing lines Patch % Lines
test/io/read_vtk.jl 90.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #959      +/-   ##
==========================================
- Coverage   89.60%   89.59%   -0.01%     
==========================================
  Files         120      120              
  Lines        8588     8634      +46     
==========================================
+ Hits         7695     7736      +41     
- Misses        893      898       +5     
Flag Coverage Δ
total 89.59% <92.00%> (-0.01%) ⬇️
unit 65.30% <92.00%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svchb svchb assigned svchb and marcelschurer and unassigned svchb Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking changes This change will break the public API and requires a new major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants