-
Notifications
You must be signed in to change notification settings - Fork 17
Add OrientedBoundingBox for spatial region analysis and particle selection
#929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LasNikas
wants to merge
22
commits into
trixi-framework:main
Choose a base branch
from
LasNikas:oriented-bbox
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+533
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #929 +/- ##
==========================================
+ Coverage 63.87% 64.06% +0.19%
==========================================
Files 117 117
Lines 7842 7931 +89
==========================================
+ Hits 5009 5081 +72
- Misses 2833 2850 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OrientedBoundingBoxOrientedBoundingBox for spatial region analysis and particle selection
svchb
previously approved these changes
Oct 2, 2025
59b2ee8 to
3c140db
Compare
6b5d276 to
a6beb81
Compare
11 tasks
svchb
previously approved these changes
Oct 23, 2025
63fa609 to
70860ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
OrientedBoundingBoxthat enables analysis of arbitrarily oriented rectangular regions within computational domains.For example: use
is_in_oriented_box(coords, box)to define measurement windows for calculating flow rates through specific cross-sections.Or for particle selection: using
intersect(ic::InitialCondition, box::OrientedBoundingBox...)- particularly useful for creating clamped particles for the TLSPH system.2D
3D
(hard to visualize but it's working)