Upgrade S3Mock test container version

Upgrade S3Mock to a version supporting S3 conditional writes.
Unfortunately, conditional multi-part writes do not work correctly in
S3Mock.

Author: findepi

lib/trino-filesystem-s3/src/test/java/io/trino/filesystem/s3/TestS3FileSystemS3Mock.java

@@ -36,15 +36,9 @@ public class TestS3FileSystemS3Mock
     private static final String BUCKET = "test-bucket";
 
     @Container
-    private static final S3MockContainer S3_MOCK = new S3MockContainer("3.0.1")
+    private static final S3MockContainer S3_MOCK = new S3MockContainer("4.10.0")
             .withInitialBuckets(BUCKET);
 
-    @Override
-    protected boolean supportsCreateExclusive()
-    {
-        return false; // not supported by s3-mock
-    }
-
     @Override
     protected String bucket()
     {
@@ -79,10 +73,23 @@ protected S3FileSystemFactory createS3FileSystemFactory()
                         .setPathStyleAccess(true)
                         .setStreamingPartSize(streamingPartSize)
                         .setSignerType(S3FileSystemConfig.SignerType.AwsS3V4Signer)
-                        .setSupportsExclusiveCreate(false),
+                        .setSupportsExclusiveCreate(true),
                 new S3FileSystemStats());
     }
 
+    @Test
+    @Override
+    public void testOutputFile()
+    {
+        // this is S3Mock bug, see https://github.com/adobe/S3Mock/issues/2790
+        assertThatThrownBy(super::testOutputFile)
+                .hasMessageContaining("""
+                        Expecting actual throwable to be an instance of:
+                          java.nio.file.FileAlreadyExistsException
+                        but was:
+                          java.io.IOException: software.amazon.awssdk.services.s3.model.S3Exception: (Service: S3, Status Code: 304""");
+    }
+
     @Test
     @Override
     public void testPreSignedUris()
@@ -91,4 +98,22 @@ public void testPreSignedUris()
         assertThatThrownBy(super::testPreSignedUris)
                 .hasMessageContaining("Expecting code to raise a throwable");
     }
+
+    @Test
+    @Override
+    public void testPaths()
+    {
+        // this is S3Mock bug, see https://github.com/adobe/S3Mock/issues/2788
+        assertThatThrownBy(super::testPaths)
+                .hasMessageContaining("S3 HEAD request failed for file: s3://test-bucket/test/.././/file");
+    }
+
+    @Test
+    @Override
+    public void testReadingEmptyFile()
+    {
+        // this is S3Mock bug, see https://github.com/adobe/S3Mock/issues/2789
+        assertThatThrownBy(super::testReadingEmptyFile)
+                .hasMessageContaining("Failed to open S3 file: s3://test-bucket/inputStream/");
+    }
 }

lib/trino-filesystem/src/test/java/io/trino/filesystem/AbstractTestTrinoFileSystem.java

@@ -580,7 +580,7 @@ public void testInputFile()
     }
 
     @Test
-    void testOutputFile()
+    public void testOutputFile()
             throws IOException
     {
         // an output file cannot be created at the root of the file system

lib/trino-hdfs/src/test/java/io/trino/filesystem/hdfs/TestHdfsFileSystemS3Mock.java

@@ -35,6 +35,7 @@
 import org.apache.hadoop.fs.Path;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.Test;
 import org.testcontainers.junit.jupiter.Container;
 import org.testcontainers.junit.jupiter.Testcontainers;
 
@@ -44,6 +45,7 @@
 
 import static java.util.Collections.emptySet;
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
 
 @Testcontainers
 public class TestHdfsFileSystemS3Mock
@@ -52,7 +54,7 @@ public class TestHdfsFileSystemS3Mock
     private static final String BUCKET = "test-bucket";
 
     @Container
-    private static final S3MockContainer S3_MOCK = new S3MockContainer("3.0.1")
+    private static final S3MockContainer S3_MOCK = new S3MockContainer("4.10.0")
             .withInitialBuckets(BUCKET);
 
     private HdfsEnvironment hdfsEnvironment;
@@ -147,4 +149,13 @@ protected void verifyFileSystemIsEmpty()
             throw new UncheckedIOException(e);
         }
     }
+
+    @Test
+    @Override
+    public void testPaths()
+    {
+        // this is S3Mock bug, see https://github.com/adobe/S3Mock/issues/2788
+        assertThatThrownBy(super::testPaths)
+                .hasMessageFindingMatch("Status Code: 400; Error Code: 400 .*\\Q(Bucket: test-bucket, Key: test/.././/file)");
+    }
 }