From 7e80d39a9025e413d14022532a9513bdb3528ed5 Mon Sep 17 00:00:00 2001 From: Georg Sauthoff Date: Sat, 7 Sep 2019 20:08:45 +0200 Subject: [PATCH 1/4] Remove unimplemented store function --- tsc_freq_khz.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/tsc_freq_khz.c b/tsc_freq_khz.c index 5a15d62..e2d3583 100644 --- a/tsc_freq_khz.c +++ b/tsc_freq_khz.c @@ -25,18 +25,11 @@ static ssize_t tsc_freq_khz_show(struct kobject *kobj, struct kobj_attribute *at return r; } -static ssize_t tsc_freq_khz_store(struct kobject *kobj, struct kobj_attribute *attr, - const char *buf, size_t count) -{ - // unimplemented - return count; -} - static struct kobj_attribute tsc_freq_khz_attribute = __ATTR(tsc_freq_khz, S_IRUGO, // world readable, unchangeable tsc_freq_khz_show, - tsc_freq_khz_store); + NULL); // store not implemented static int __init tsc_khz_init(void){ struct device *dev; @@ -73,4 +66,4 @@ static void __exit tsc_khz_exit(void) { } module_init(tsc_khz_init); -module_exit(tsc_khz_exit); \ No newline at end of file +module_exit(tsc_khz_exit); From 935f60015398b9f5586c475cebfa7b83630e2ff0 Mon Sep 17 00:00:00 2001 From: Georg Sauthoff Date: Sat, 7 Sep 2019 20:13:49 +0200 Subject: [PATCH 2/4] Fix format string --- tsc_freq_khz.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tsc_freq_khz.c b/tsc_freq_khz.c index e2d3583..d9a3f67 100644 --- a/tsc_freq_khz.c +++ b/tsc_freq_khz.c @@ -21,7 +21,7 @@ static ssize_t tsc_freq_khz_show(struct kobject *kobj, struct kobj_attribute *at char *buf) { ssize_t r; - r = sprintf(buf, "%d\n", tsc_khz); + r = sprintf(buf, "%u\n", tsc_khz); return r; } From de51b20392eb2ca52d888ad994af4a8cada4f5a6 Mon Sep 17 00:00:00 2001 From: Georg Sauthoff Date: Sat, 7 Sep 2019 20:20:02 +0200 Subject: [PATCH 3/4] Fix include --- tsc_freq_khz.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tsc_freq_khz.c b/tsc_freq_khz.c index d9a3f67..f81f3d1 100644 --- a/tsc_freq_khz.c +++ b/tsc_freq_khz.c @@ -2,8 +2,7 @@ #include #include #include -//#include -extern unsigned int tsc_khz; +#include // extern unsigned int tsc_khz; #include #include #include From 2b881ceeea9edc5fdb426ad55399eb1eb6067451 Mon Sep 17 00:00:00 2001 From: Georg Sauthoff Date: Sat, 7 Sep 2019 20:22:29 +0200 Subject: [PATCH 4/4] Fix indentation --- tsc_freq_khz.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tsc_freq_khz.c b/tsc_freq_khz.c index f81f3d1..1c6d505 100644 --- a/tsc_freq_khz.c +++ b/tsc_freq_khz.c @@ -54,14 +54,14 @@ static int __init tsc_khz_init(void){ } static void __exit tsc_khz_exit(void) { - struct device *dev; - printk(KERN_INFO DRIVER_NAME ": unloading driver\n"); - dev = get_cpu_device(0); // assumes always a cpu0 - if (!dev) { - printk(KERN_INFO DRIVER_NAME ": could not get device for CPU %d\n", 0); - return; - } - sysfs_remove_file(&dev->kobj, &tsc_freq_khz_attribute.attr); + struct device *dev; + printk(KERN_INFO DRIVER_NAME ": unloading driver\n"); + dev = get_cpu_device(0); // assumes always a cpu0 + if (!dev) { + printk(KERN_INFO DRIVER_NAME ": could not get device for CPU %d\n", 0); + return; + } + sysfs_remove_file(&dev->kobj, &tsc_freq_khz_attribute.attr); } module_init(tsc_khz_init);