remove legacy

Author: doronkopit5

src/opentelemetry_mcp/attributes.py

@@ -6,7 +6,7 @@
 
 # Note: We import constants for documentation but must use string literals for Pydantic aliases
 # due to mypy strict mode requirements
-from .constants import GenAI, LegacyLLM, Service, Status  # noqa: F401
+from .constants import GenAI
 
 
 class SpanAttributes(BaseModel):

src/opentelemetry_mcp/backends/jaeger.py

@@ -59,7 +59,7 @@ async def search_traces(self, query: TraceQuery) -> list[TraceData]:
                 "Use list_services() to see available services, then specify one with service_name parameter."
             )
 
-        # Get all filters (legacy + explicit)
+        # Get all filters (converted + explicit)
         all_filters = query.get_all_filters()
 
         # Jaeger only supports service filtering via API (via query.to_backend_params())
@@ -98,7 +98,7 @@ async def _search_service_traces_with_filters(
         Returns:
             List of matching traces
         """
-        # Use legacy to_backend_params for now (handles service, operation, duration, time, tags)
+        # Use to_backend_params for now (handles service, operation, duration, time, tags)
         params = query.to_backend_params()
 
         logger.debug(f"Searching traces with params: {params}")
@@ -143,7 +143,7 @@ async def search_spans(self, query: SpanQuery) -> list[SpanData]:
                 "Use list_services() to see available services, then specify one with service_name parameter."
             )
 
-        # Get all filters (legacy + explicit)
+        # Get all filters (converted + explicit)
         all_filters = query.get_all_filters()
 
         # Jaeger only supports service filtering via API

src/opentelemetry_mcp/backends/tempo.py

@@ -67,7 +67,7 @@ async def search_traces(self, query: TraceQuery) -> list[TraceData]:
         Raises:
             httpx.HTTPError: If API request fails
         """
-        # Get all filters (legacy + explicit)
+        # Get all filters (converted + explicit)
         all_filters = query.get_all_filters()
 
         # Separate supported and unsupported filters
@@ -153,7 +153,7 @@ async def search_spans(self, query: SpanQuery) -> list[SpanData]:
         Raises:
             httpx.HTTPError: If API request fails
         """
-        # Get all filters (legacy + explicit)
+        # Get all filters (converted + explicit)
         all_filters = query.get_all_filters()
 
         # For span queries, we need to be careful about which filters to push to TraceQL
@@ -485,7 +485,7 @@ def _filter_to_traceql(self, filter_obj: Filter) -> str | None:
         return None
 
     def _build_traceql_query(self, query: TraceQuery) -> str:
-        """Build TraceQL query from query parameters (legacy method).
+        """Build TraceQL query from query parameters.
 
         This method is kept for backward compatibility. New code should use
         _build_traceql_from_filters with query.get_all_filters().

src/opentelemetry_mcp/backends/traceloop.py

@@ -99,7 +99,7 @@ async def search_traces(self, query: TraceQuery) -> list[TraceData]:
         """
         logger.debug(f"Searching traces with query: {query}")
 
-        # Get all filters (legacy + explicit)
+        # Get all filters
         all_filters = query.get_all_filters()
 
         # Separate supported and unsupported filters by operator
@@ -192,7 +192,7 @@ async def search_spans(self, query: SpanQuery) -> list[SpanData]:
         """
         logger.debug(f"Searching spans with query: {query}")
 
-        # Get all filters (legacy + explicit)
+        # Get all filters
         all_filters = query.get_all_filters()
 
         # Separate supported and unsupported filters by operator

src/opentelemetry_mcp/models.py

@@ -82,7 +82,7 @@ def validate_filter_values(self) -> "Filter":
         return self
 
 
-def _convert_legacy_params_to_filters(
+def _convert_params_to_filters(
     service_name: str | None = None,
     operation_name: str | None = None,
     min_duration_ms: int | None = None,
@@ -94,7 +94,7 @@ def _convert_legacy_params_to_filters(
     tags: dict[str, str] | None = None,
     explicit_filters: list[Filter] | None = None,
 ) -> list[Filter]:
-    """Convert legacy query parameters to Filter objects and combine with explicit filters.
+    """Convert query parameters to Filter objects and combine with explicit filters.
 
     This helper function is used by both TraceQuery and SpanQuery to avoid code duplication.
 
@@ -111,11 +111,11 @@ def _convert_legacy_params_to_filters(
         explicit_filters: Explicit Filter objects to append
 
     Returns:
-        Combined list of all filters (legacy converted + explicit)
+        Combined list of all filters (converted + explicit)
     """
     all_filters: list[Filter] = []
 
-    # Convert legacy parameters to filters
+    # Convert parameters to filters
     if service_name:
         all_filters.append(
             Filter(
@@ -460,7 +460,7 @@ def total_llm_tokens(self) -> int:
 class TraceQuery(BaseModel):
     """Query parameters for searching traces."""
 
-    # Legacy simple parameters (for backward compatibility)
+    # Simple parameters
     service_name: str | None = None
     operation_name: str | None = None
     start_time: datetime | None = None
@@ -471,7 +471,7 @@ class TraceQuery(BaseModel):
     limit: int = Field(default=100, ge=1, le=1000)
     has_error: bool | None = None
 
-    # Opentelemetry-specific filters (legacy)
+    # Opentelemetry-specific filters
     gen_ai_system: str | None = None  # Filter by LLM provider
     gen_ai_request_model: str | None = None  # Filter by requested model
     gen_ai_response_model: str | None = None  # Filter by actual model used
@@ -483,7 +483,7 @@ class TraceQuery(BaseModel):
     )
 
     def has_filters(self) -> bool:
-        """Check if any filters (legacy or new) are specified."""
+        """Check if any filters are specified."""
         return bool(
             self.service_name
             or self.operation_name
@@ -498,12 +498,12 @@ def has_filters(self) -> bool:
         )
 
     def get_all_filters(self) -> list[Filter]:
-        """Convert legacy parameters to Filter objects and combine with explicit filters.
+        """Convert parameters to Filter objects and combine with explicit filters.
 
         Returns:
-            Combined list of all filters (legacy converted + explicit)
+            Combined list of all filters (converted + explicit)
         """
-        return _convert_legacy_params_to_filters(
+        return _convert_params_to_filters(
             service_name=self.service_name,
             operation_name=self.operation_name,
             min_duration_ms=self.min_duration_ms,
@@ -631,12 +631,12 @@ def has_filters(self) -> bool:
         )
 
     def get_all_filters(self) -> list[Filter]:
-        """Convert legacy parameters to Filter objects and combine with explicit filters.
+        """Convert parameters to Filter objects and combine with explicit filters.
 
         Returns:
-            Combined list of all filters (legacy converted + explicit)
+            Combined list of all filters (converted + explicit)
         """
-        return _convert_legacy_params_to_filters(
+        return _convert_params_to_filters(
             service_name=self.service_name,
             operation_name=self.operation_name,
             min_duration_ms=self.min_duration_ms,

src/opentelemetry_mcp/server.py

@@ -151,20 +151,20 @@ async def search_traces(
 ) -> str:
     """Search for OpenTelemetry traces with filters.
 
-    Supports both simple parameters (legacy) and advanced generic filter system.
+    Supports both simple parameters and advanced generic filter system.
 
     Args:
-        service_name: Filter by service name (legacy - use filters for advanced queries)
-        operation_name: Filter by operation/span name (legacy)
+        service_name: Filter by service name (use filters for advanced queries)
+        operation_name: Filter by operation/span name
         start_time: Start time in ISO 8601 format (e.g., 2024-01-01T00:00:00Z)
         end_time: End time in ISO 8601 format
-        min_duration_ms: Minimum trace duration in milliseconds (legacy)
-        max_duration_ms: Maximum trace duration in milliseconds (legacy)
-        gen_ai_system: Filter by LLM provider (legacy - e.g., openai, anthropic)
+        min_duration_ms: Minimum trace duration in milliseconds
+        max_duration_ms: Maximum trace duration in milliseconds
+        gen_ai_system: Filter by LLM provider (e.g., openai, anthropic)
         gen_ai_request_model: Filter by requested model name (e.g., gpt-4)
         gen_ai_response_model: Filter by actual model used (e.g., gpt-4-0613)
-        has_error: Filter traces with errors (legacy)
-        tags: Additional tag filters as key-value pairs (legacy)
+        has_error: Filter traces with errors
+        tags: Additional tag filters as key-value pairs
         filters: Generic filter conditions (advanced) - list of filter objects with:
             - field: Field name in dotted notation (e.g., "gen_ai.usage.prompt_tokens")
             - operator: Comparison operator (equals, not_equals, gt, lt, gte, lte, contains,

src/opentelemetry_mcp/tools/search.py

@@ -28,21 +28,21 @@ async def search_traces(
 ) -> str:
     """Search for OpenTelemetry traces with optional filters.
 
-    Supports both legacy simple parameters and the new generic filter system.
+    Supports both simple parameters and the new generic filter system.
 
     Args:
         backend: Backend instance to query
-        service_name: Filter by service name (legacy parameter)
-        operation_name: Filter by operation/span name (legacy parameter)
+        service_name: Filter by service name
+        operation_name: Filter by operation/span name
         start_time: Start time (ISO 8601 format)
         end_time: End time (ISO 8601 format)
-        min_duration_ms: Minimum trace duration in milliseconds (legacy parameter)
-        max_duration_ms: Maximum trace duration in milliseconds (legacy parameter)
-        gen_ai_system: Filter by LLM provider (legacy parameter)
+        min_duration_ms: Minimum trace duration in milliseconds
+        max_duration_ms: Maximum trace duration in milliseconds
+        gen_ai_system: Filter by LLM provider
         gen_ai_request_model: Filter by requested model name
         gen_ai_response_model: Filter by actual model used
-        has_error: Filter traces with errors (legacy parameter)
-        tags: Additional tag filters as key-value pairs (legacy parameter)
+        has_error: Filter traces with errors
+        tags: Additional tag filters as key-value pairs
         filters: Generic filter conditions (list of filter objects)
         limit: Maximum number of traces to return (1-1000)