refactor(clippy): fix warnings

Author: kpp

tox_core/src/dht/kbucket.rs

@@ -226,7 +226,7 @@ where
                             "No free space left in the kbucket, the last bad node removed.");
                         // replace the farthest bad node
                         self.nodes.remove(eviction_index);
-                        let index = index - if eviction_index < index { 1 } else { 0 };
+                        let index = index - usize::from(eviction_index < index);
                         self.nodes.insert(index, new_node.into());
                         true
                     } else {
@@ -251,7 +251,7 @@ where
                         "No free space left in the kbucket, the last (bad) node removed.");
                     let eviction_index = Node::eviction_index(&self.nodes).unwrap_or(self.nodes.len() - 1);
                     self.nodes.remove(eviction_index);
-                    let index = index - if eviction_index < index { 1 } else { 0 };
+                    let index = index - usize::from(eviction_index < index);
                     self.nodes.insert(index, new_node.into());
                 } else {
                     self.nodes.insert(index, new_node.into());

tox_core/src/dht/server/mod.rs

@@ -870,10 +870,10 @@ impl Server {
         if state.check_ping_id(payload.id, &packet.pk) {
             trace!("Received nodes with NodesResponse from {}: {:?}", addr, payload.nodes);
 
-            self.try_add_to_close(&mut *state, payload.id, PackedNode::new(addr, packet.pk.clone()), false).await?;
+            self.try_add_to_close(&mut state, payload.id, PackedNode::new(addr, packet.pk.clone()), false).await?;
 
             // Process nodes from NodesResponse
-            self.add_bootstrap_nodes(&mut *state, &payload.nodes, &packet.pk).await;
+            self.add_bootstrap_nodes(&mut state, &payload.nodes, &packet.pk).await;
         } else {
             // Some old version toxcore responds with wrong ping_id.
             // So we do not treat this as our own error.

tox_core/src/net_crypto/mod.rs

@@ -280,7 +280,7 @@ impl NetCrypto {
     /// or disconnected.
     async fn send_connection_status(&self, connection: &CryptoConnection, status: bool) -> Result<(), mpsc::SendError> {
         if connection.is_established() != status {
-            let tx = (&*self.connection_status_tx.read().await).clone();
+            let tx = (*self.connection_status_tx.read().await).clone();
             maybe_send_unbounded(tx, (connection.peer_real_pk.clone(), status)).await
         } else {
             Ok(())

tox_core/src/onion/onion_announce.rs

@@ -155,7 +155,7 @@ impl OnionPingData {
         let mut buf = [0; ONION_PING_DATA_SIZE];
         // can not fail since buf has enough length
         self.to_bytes((&mut buf, 0)).unwrap();
-        Sha256::digest(&buf).into()
+        Sha256::digest(buf).into()
     }
 }
 

tox_core/src/relay/client/connections.rs

@@ -217,7 +217,7 @@ impl Connections {
         if let Some(connection) = connections.get(&node_pk) {
             let clients = self.clients.read().await;
 
-            for c in connection.clients(&*clients) {
+            for c in connection.clients(&clients) {
                 let res = c.send_data(node_pk.clone(), data.clone()).await;
 
                 if res.is_ok() { break }

tox_node/src/node_config.rs

@@ -234,7 +234,7 @@ fn app() -> Command {
             .help("Node to perform initial bootstrap")
             .num_args(2)
             .action(clap::ArgAction::Append)
-            .value_names(&["public key", "address"]))
+            .value_names(["public key", "address"]))
         .group(ArgGroup::new("req_flags")
             .args(["bootstrap-node", "tcp-address"])
             .multiple(true))