refactor(crypto): remove crypto_init

Author: kurnevsky

examples/dht_server.rs

@@ -33,10 +33,6 @@ fn as_packed_node(pk: &str, saddr: &str) -> PackedNode {
 async fn main() -> Result<(), Error> {
     env_logger::init();
 
-    if crypto_init().is_err() {
-        panic!("Crypto initialization failed.");
-    }
-
     let (server_pk, server_sk) = gen_keypair();
 
     // Create a channel for server to communicate with network

tox_binary_io/src/lib.rs

@@ -108,11 +108,9 @@ equals original value. Type of this value should implement `ToBytes`,
 */
 #[macro_export]
 macro_rules! encode_decode_test (
-    ($init:expr, $test:ident, $value:expr) => (
+    ($test:ident, $value:expr) => (
         #[test]
         fn $test() {
-            $init;
-
             let value = $value;
             let mut buf = [0; 1024 * 1024];
             let (_, size) = value.to_bytes((&mut buf, 0)).unwrap();

tox_core/src/dht/codec.rs

@@ -171,7 +171,6 @@ mod tests {
 
     #[test]
     fn encode_decode() {
-        crypto_init().unwrap();
         let test_packets = vec![
             Packet::PingRequest(PingRequest {
                 pk: gen_keypair().0,
@@ -315,7 +314,6 @@ mod tests {
 
     #[test]
     fn decode_encrypted_packet_incomplete() {
-        crypto_init().unwrap();
         let stats = Stats::new();
         let mut codec = DhtCodec::new(stats);
         let mut buf = BytesMut::new();
@@ -334,7 +332,6 @@ mod tests {
 
     #[test]
     fn decode_encrypted_packet_error() {
-        crypto_init().unwrap();
         let stats = Stats::new();
         let mut codec = DhtCodec::new(stats);
         let mut buf = BytesMut::new();
@@ -349,7 +346,6 @@ mod tests {
 
     #[test]
     fn decode_encrypted_packet_zero_length() {
-        crypto_init().unwrap();
         let stats = Stats::new();
         let mut codec = DhtCodec::new(stats);
         let mut buf = BytesMut::new();
@@ -360,7 +356,6 @@ mod tests {
 
     #[test]
     fn encode_packet_too_big() {
-        crypto_init().unwrap();
         let stats = Stats::new();
         let mut codec = DhtCodec::new(stats);
         let mut buf = BytesMut::new();

tox_core/src/dht/daemon_state.rs

@@ -112,7 +112,6 @@ mod tests {
 
     #[tokio::test]
     async fn daemon_state_serialize_deserialize() {
-        crypto_init().unwrap();
         let (pk, sk) = gen_keypair();
         let (tx, rx) = mpsc::channel(1);
         let alice = Server::new(tx, pk, sk);

tox_core/src/dht/dht_friend.rs

@@ -103,7 +103,6 @@ mod tests {
 
     #[test]
     fn addr_is_unknown() {
-        crypto_init().unwrap();
         let pk = gen_keypair().0;
         let mut friend = DhtFriend::new(&mut thread_rng(), pk);
 
@@ -115,7 +114,6 @@ mod tests {
 
     #[test]
     fn addr_is_known() {
-        crypto_init().unwrap();
         let pk = gen_keypair().0;
         let mut friend = DhtFriend::new(&mut thread_rng(), pk);
 
@@ -129,7 +127,6 @@ mod tests {
 
     #[test]
     fn get_returned_addrs() {
-        crypto_init().unwrap();
         let pk = gen_keypair().0;
         let mut friend = DhtFriend::new(&mut thread_rng(), pk);
 
@@ -162,7 +159,6 @@ mod tests {
 
     #[tokio::test]
     async fn get_returned_addrs_timed_out() {
-        crypto_init().unwrap();
         let pk = gen_keypair().0;
         let mut friend = DhtFriend::new(&mut thread_rng(), pk);
 
@@ -191,7 +187,6 @@ mod tests {
 
     #[test]
     fn can_and_try_add_to_close() {
-        crypto_init().unwrap();
         let pk = PublicKey([0; PUBLICKEYBYTES]);
         let mut friend = DhtFriend::new(&mut thread_rng(), pk);
 

tox_core/src/dht/forced_ktree.rs

@@ -279,7 +279,6 @@ mod tests {
 
     #[test]
     fn forced_ktree_contains() {
-        crypto_init().unwrap();
         let (pk, _) = gen_keypair();
         let mut ktree = ForcedKtree::new(&pk);
 
@@ -309,7 +308,6 @@ mod tests {
 
     #[test]
     fn forced_ktree_can_add() {
-        crypto_init().unwrap();
         let pk = PublicKey([0; PUBLICKEYBYTES]);
         let mut ktree = ForcedKtree::new(&pk);
 
@@ -412,7 +410,6 @@ mod tests {
 
     #[tokio::test]
     async fn forced_ktree_is_all_discarded() {
-        crypto_init().unwrap();
         let (pk, _) = gen_keypair();
         let mut ktree = ForcedKtree::new(&pk);
 

tox_core/src/dht/kbucket.rs

@@ -613,7 +613,6 @@ mod tests {
 
     #[test]
     fn kbucket_get_node() {
-        crypto_init().unwrap();
         let (pk, _) = gen_keypair();
         let mut kbucket = Kbucket::<DhtNode>::new(KBUCKET_DEFAULT_SIZE);
 
@@ -630,7 +629,6 @@ mod tests {
 
     #[test]
     fn kbucket_get_node_mut() {
-        crypto_init().unwrap();
         let (pk, _) = gen_keypair();
         let mut kbucket = Kbucket::<DhtNode>::new(KBUCKET_DEFAULT_SIZE);
 

tox_core/src/dht/ktree.rs

@@ -213,7 +213,6 @@ mod tests {
 
     #[test]
     fn ktree_new() {
-        crypto_init().unwrap();
         let pk = gen_keypair().0;
         let ktree = Ktree::new(&pk);
         assert_eq!(pk, ktree.pk);
@@ -326,7 +325,6 @@ mod tests {
 
     #[test]
     fn ktree_contains() {
-        crypto_init().unwrap();
         let (pk, _) = gen_keypair();
         let mut ktree = Ktree::new(&pk);
 
@@ -346,7 +344,6 @@ mod tests {
 
     #[test]
     fn ktree_can_add() {
-        crypto_init().unwrap();
         let (pk, _) = gen_keypair();
         let mut ktree = Ktree::new(&pk);
 
@@ -418,7 +415,6 @@ mod tests {
 
     #[tokio::test]
     async fn ktree_is_all_discarded() {
-        crypto_init().unwrap();
         let (pk, _) = gen_keypair();
         let mut ktree = Ktree::new(&pk);
 

tox_core/src/dht/lan_discovery.rs

@@ -175,7 +175,6 @@ mod tests {
 
     #[tokio::test]
     async fn send_ipv4() {
-        crypto_init().unwrap();
         // `+1` for 255.255.255.255
         let packets_count = (broadcast_addrs_count() + 1) * (PORTS_PER_DISCOVERY + 1) as usize;
 
@@ -201,7 +200,6 @@ mod tests {
 
     #[tokio::test]
     async fn send_ipv6() {
-        crypto_init().unwrap();
         // `+2` for ::1 and ::ffff:255.255.255.255
         let packets_count = (broadcast_addrs_count() + 2) * (PORTS_PER_DISCOVERY + 1) as usize;
 
@@ -227,7 +225,6 @@ mod tests {
 
     #[tokio::test]
     async fn cycle_around_ports() {
-        crypto_init().unwrap();
         // `+1` for 255.255.255.255
         let packets_count = (broadcast_addrs_count() + 1) * (PORTS_PER_DISCOVERY + 1) as usize;
 

tox_core/src/dht/server/mod.rs

@@ -1396,8 +1396,6 @@ mod tests {
 
     fn create_node() -> (Server, PrecomputedKey, PublicKey, SecretKey,
             mpsc::Receiver<(Packet, SocketAddr)>, SocketAddr) {
-        crypto_init().unwrap();
-
         let (pk, sk) = gen_keypair();
         let (tx, rx) = mpsc::channel(32);
         let alice = Server::new(tx, pk, sk);