fix: improve connection pool and server metrics display

- Fix connection count calculation in MonitorManager to use visible connections from SHOW PROCESSLIST instead of Threads_connected
- Fix visibleHeight calculation in ConnectionPoolPane to correctly display all connections
- Add support for Oracle connection IDs (sid) and schema names in ConnectionPoolPane
- Fix SchemaBrowserPane to handle array table data correctly
- Improve ServerMetricsPane metric labels for clarity:
  - visible_connections -> Connections (matches ConnectionPoolPane)
  - threads_connected -> Current Connections
  - threads_running -> Active Queries
  - questions -> Queries (session)
  - connections -> Connections (lifetime)
- Fix uptime retrieval in MySQL/MariaDB dialects to use rawQuery instead of rawQueryValue

Author: tommyknocker

src/cli/MonitorManager.php

@@ -172,12 +172,12 @@ protected static function getActiveConnectionsMySQL(PdoDb $db): array
         }
 
         // Get connection limits
-        $status = $db->rawQuery("SHOW STATUS LIKE 'Threads_connected'");
+        // Use count of visible connections from SHOW PROCESSLIST for current
+        // (SHOW PROCESSLIST only shows connections user has permission to see)
         $maxConn = $db->rawQuery("SHOW VARIABLES LIKE 'max_connections'");
-        $currentVal = $status[0]['Value'] ?? 0;
         $maxVal = $maxConn[0]['Value'] ?? 0;
-        $current = is_int($currentVal) ? $currentVal : (is_string($currentVal) ? (int)$currentVal : 0);
         $max = is_int($maxVal) ? $maxVal : (is_string($maxVal) ? (int)$maxVal : 0);
+        $current = count($result); // Use actual count of visible connections
 
         return [
             'connections' => $result,

src/cli/ui/panes/ConnectionPoolPane.php

@@ -137,20 +137,23 @@ public static function render(PdoDb $db, Layout $layout, int $paneIndex, bool $a
             }
 
             // Calculate visible height for connections list
-            // Content area includes: summary (3 rows) + label (1 row) + table header (1 row) + connections list
+            // Content area includes: summary (3 rows) + spacing (2 rows) + label (1 row) + table header (1 row) + connections list
             // In fullscreen: content['height'] = $rows - 2 (header + footer)
             // Connections list starts at row 8 (after summary 3 rows + spacing 2 rows + label 1 row + table header 1 row)
             // Footer is at row $rows, so last connection row = $rows - 1
             // Visible height = ($rows - 1) - 8 + 1 = $rows - 8
             $summaryHeight = 3;
+            $spacingHeight = 2; // Spacing after summary (row += 2)
             $labelHeight = 1;
             $tableHeaderHeight = 1;
             if ($fullscreen) {
                 // In fullscreen: header (row 1) + summary (rows 2-4) + spacing (row 5) + label (row 6) + table header (row 7) + list (starts row 8) + footer (row $rows)
                 // Visible height = $rows - 1 (footer) - 7 (header + summary + spacing + label + table header) = $rows - 8
-                $visibleHeight = $rows - 1 - ($summaryHeight + 2 + $labelHeight + $tableHeaderHeight); // +2 for spacing before label
+                $visibleHeight = $rows - 1 - ($summaryHeight + $spacingHeight + $labelHeight + $tableHeaderHeight);
             } else {
-                $visibleHeight = $content['height'] - $summaryHeight - 2; // -2 for header and spacing
+                // In normal mode: summary (3 rows) + spacing (2 rows) + label (1 row) + table header (1 row) = 7 rows used
+                // Available for connections = content['height'] - 7
+                $visibleHeight = $content['height'] - $summaryHeight - $spacingHeight - $labelHeight - $tableHeaderHeight;
             }
 
             $colWidth = (int)floor($content['width'] / 3);
@@ -199,9 +202,9 @@ public static function render(PdoDb $db, Layout $layout, int $paneIndex, bool $a
                     Terminal::color(Terminal::COLOR_BLACK);
                 }
 
-                $id = self::truncate((string)($conn['id'] ?? $conn['pid'] ?? $conn['session_id'] ?? ''), $colWidth);
+                $id = self::truncate((string)($conn['id'] ?? $conn['pid'] ?? $conn['session_id'] ?? $conn['sid'] ?? ''), $colWidth);
                 $user = self::truncate((string)($conn['user'] ?? $conn['usename'] ?? $conn['login'] ?? ''), $colWidth);
-                $dbName = self::truncate((string)($conn['db'] ?? $conn['database'] ?? $conn['datname'] ?? ''), $content['width'] - ($colWidth * 2));
+                $dbName = self::truncate((string)($conn['db'] ?? $conn['database'] ?? $conn['datname'] ?? $conn['schema'] ?? ''), $content['width'] - ($colWidth * 2));
 
                 $marker = $isSelected ? '> ' : '  ';
                 $rowText = $marker . str_pad($id, $colWidth - 2) . str_pad($user, $colWidth) . $dbName;

src/cli/ui/panes/SchemaBrowserPane.php

@@ -152,8 +152,11 @@ protected static function renderFullscreen(PdoDb $db, array $content, array $tab
                 Terminal::color(Terminal::COLOR_BLACK);
             }
 
+            // Extract table name if $table is an array, otherwise use string directly
+            $tableName = is_array($table) ? ($table['name'] ?? (string)($table[0] ?? '')) : (string)$table;
+
             $marker = $isSelected ? '> ' : '  ';
-            $tableText = $marker . $table;
+            $tableText = $marker . $tableName;
             if (mb_strlen($tableText, 'UTF-8') > $content['width']) {
                 $tableText = mb_substr($tableText, 0, $content['width'] - 3, 'UTF-8') . '...';
             }

src/cli/ui/panes/ServerMetricsPane.php

@@ -77,13 +77,15 @@ public static function render(PdoDb $db, Layout $layout, int $paneIndex, bool $a
 
         // Display key metrics (dialect-specific)
         // Note: Questions and Queries are cumulative counters since server start
+        // Use visible_connections if available (matches ConnectionPoolPane), otherwise fall back to threads_connected
         $keyMetrics = [
-            'threads_connected' => 'Connections',
-            'threads_running' => 'Running',
-            'questions' => 'Questions (total)',
+            'visible_connections' => 'Connections',
+            'threads_connected' => 'Current Connections',
+            'threads_running' => 'Active Queries',
+            'questions' => 'Queries (session)',
             'queries' => 'Queries (total)',
             'slow_queries' => 'Slow Queries',
-            'connections' => 'Connections',
+            'connections' => 'Connections (lifetime)',
             'commits' => 'Commits',
             'rollbacks' => 'Rollbacks',
             'sessions' => 'Sessions',

src/dialects/mariadb/MariaDBDialect.php

@@ -1582,8 +1582,9 @@ public function getServerMetrics(PdoDb $db): array
             $metrics['version'] = is_string($version) ? $version : 'unknown';
 
             // Get uptime
-            $uptime = $db->rawQueryValue("SHOW STATUS WHERE Variable_name = 'Uptime'");
-            $uptimeValue = is_int($uptime) ? $uptime : (is_string($uptime) ? (int)$uptime : 0);
+            $uptimeResult = $db->rawQuery("SHOW STATUS WHERE Variable_name = 'Uptime'");
+            $uptimeValue = $uptimeResult[0]['Value'] ?? 0;
+            $uptimeValue = is_int($uptimeValue) ? $uptimeValue : (is_string($uptimeValue) ? (int)$uptimeValue : 0);
             $metrics['uptime_seconds'] = $uptimeValue;
 
             // Get key status variables

src/dialects/mysql/MySQLDialect.php

@@ -1625,8 +1625,9 @@ public function getServerMetrics(PdoDb $db): array
             $metrics['version'] = is_string($version) ? $version : 'unknown';
 
             // Get uptime
-            $uptime = $db->rawQueryValue("SHOW STATUS WHERE Variable_name = 'Uptime'");
-            $uptimeValue = is_int($uptime) ? $uptime : (is_string($uptime) ? (int)$uptime : 0);
+            $uptimeResult = $db->rawQuery("SHOW STATUS WHERE Variable_name = 'Uptime'");
+            $uptimeValue = $uptimeResult[0]['Value'] ?? 0;
+            $uptimeValue = is_int($uptimeValue) ? $uptimeValue : (is_string($uptimeValue) ? (int)$uptimeValue : 0);
             $metrics['uptime_seconds'] = $uptimeValue;
 
             // Get key status variables