chore: Update named-functions rule to enforce named function declarations

Author: tomerh2001

README.md

@@ -20,7 +20,7 @@ This repository contains custom ESLint rules to enhance code quality and consist
 
 | Name                                                 | Description                                                                      | 💼                                  | 🔧 |
 | :--------------------------------------------------- | :------------------------------------------------------------------------------- | :---------------------------------- | :- |
-| [named-functions](docs/rules/named-functions.md)     | Enforce top-level functions to be named functions                                | ✅ ![badge-recommended-typescript][] | 🔧 |
+| [named-functions](docs/rules/named-functions.md)     | Enforce top-level functions to be named function declarations                    | ✅ ![badge-recommended-typescript][] | 🔧 |
 | [no-comments](docs/rules/no-comments.md)             | Disallow comments except for specified allowed patterns.                         | ✅ ![badge-recommended-typescript][] | 🔧 |
 | [no-default-export](docs/rules/no-default-export.md) | Convert unnamed default exports to named default exports based on the file name. | ✅ ![badge-recommended-typescript][] | 🔧 |
 | [no-destructuring](docs/rules/no-destructuring.md)   | Disallow destructuring that does not meet certain conditions                     | ✅ ![badge-recommended-typescript][] |    |

docs/rules/named-functions.md

@@ -1,4 +1,4 @@
-# Enforce top-level functions to be named functions (`th-rules/named-functions`)
+# Enforce top-level functions to be named function declarations (`th-rules/named-functions`)
 
 💼 This rule is enabled in the following configs: ✅ `recommended`, `recommended-typescript`.
 

src/rules/named-functions.js

@@ -2,42 +2,48 @@ module.exports = {
   meta: {
     type: 'problem',
     docs: {
-      description: 'Enforce top-level functions to be named functions',
+      description: 'Enforce top-level functions to be named function declarations',
       url: 'https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/named-functions.md',
     },
     fixable: 'code',
     schema: [],
   },
 
   create(context) {
-    function reportAndFix(node, name) {
+    function reportAndFix(node, varName) {
       context.report({
         node,
         message: 'Top-level functions must be named function declarations.',
         fix(fixer) {
-          if (node.type === 'FunctionExpression' && node.parent.type === 'VariableDeclarator') {
-            // Convert to a function declaration
-            const sourceCode = context.getSourceCode();
-            const varName = node.parent.id.name;
+          const sourceCode = context.getSourceCode();
+
+          if (node.type === 'ArrowFunctionExpression') {
+            // Convert arrow function to a named function declaration
             const functionBody = sourceCode.getText(node.body);
             const functionParams = sourceCode.getText(node.params);
             const asyncKeyword = node.async ? 'async ' : '';
-            const generatorKeyword = node.generator ? '*' : '';
 
-            const functionDeclaration = `${asyncKeyword}function ${generatorKeyword}${varName}(${functionParams}) ${functionBody}`;
-            return fixer.replaceText(node.parent.parent, functionDeclaration);
+            let functionDeclaration;
+
+            if (node.body.type === 'BlockStatement') {
+              functionDeclaration = `${asyncKeyword}function ${varName}(${functionParams}) ${functionBody}`;
+            } else {
+              // For concise body (single expression)
+              functionDeclaration = `${asyncKeyword}function ${varName}(${functionParams}) { return ${functionBody}; }`;
+            }
+
+            return fixer.replaceText(node.parent, functionDeclaration);
           }
 
           if (node.type === 'FunctionExpression') {
-            // Convert to a function declaration
-            const sourceCode = context.getSourceCode();
+            // Convert anonymous function expression to named function declaration
             const functionBody = sourceCode.getText(node.body);
             const functionParams = sourceCode.getText(node.params);
             const asyncKeyword = node.async ? 'async ' : '';
             const generatorKeyword = node.generator ? '*' : '';
 
-            const functionDeclaration = `${asyncKeyword}function ${generatorKeyword}${name}(${functionParams}) ${functionBody}`;
-            return fixer.replaceText(node, functionDeclaration);
+            const functionDeclaration = `${asyncKeyword}function ${generatorKeyword}${varName}(${functionParams}) ${functionBody}`;
+            return fixer.replaceText(node.parent, functionDeclaration);
           }
 
           return null;
@@ -47,31 +53,29 @@ module.exports = {
 
     return {
       Program(programNode) {
-        const topLevelNodes = programNode.body;
-
-        topLevelNodes.forEach((node) => {
-          if (node.type === 'FunctionDeclaration') {
-            // Skip if already a named function declaration
-            return;
+        programNode.body.forEach((node) => {
+          // Handle VariableDeclaration (e.g. const function_ = () => {})
+          if (node.type === 'VariableDeclaration') {
+            node.declarations.forEach((declaration) => {
+              // Ensure that declaration.init is defined and that it's a function expression or arrow function
+              if (
+                declaration.init &&
+                (declaration.init.type === 'ArrowFunctionExpression' || declaration.init.type === 'FunctionExpression')
+              ) {
+                const varName = declaration.id.name;
+                reportAndFix(declaration.init, varName);
+              }
+            });
           }
 
-          if (
-            node.type === 'FunctionExpression' ||
-            (node.type === 'VariableDeclaration' && node.declarations[0].init?.type === 'FunctionExpression')
-          ) {
-            // Force it to be a named function declaration
-            if (node.type === 'VariableDeclaration') {
-              const varName = node.declarations[0].id.name;
-              reportAndFix(node.declarations[0].init, varName);
-            } else {
-              reportAndFix(node, 'Anonymous');
-            }
+          // Handle anonymous top-level function declarations
+          if (node.type === 'FunctionDeclaration' && !node.id) {
+            reportAndFix(node, 'Anonymous');
           }
 
+          // Handle ExpressionStatement for top-level arrow function (though uncommon)
           if (node.type === 'ExpressionStatement' && node.expression.type === 'ArrowFunctionExpression') {
-            // Convert arrow functions into named function declarations
-            const varName = node.expression.id ? node.expression.id.name : 'Anonymous';
-            reportAndFix(node.expression, varName);
+            reportAndFix(node.expression, 'Anonymous');
           }
         });
       },

src/rules/no-default-export.js

@@ -3,7 +3,7 @@
 const path = require('node:path');
 
 const meta = {
-	type: 'suggestion',
+	type: 'problem',
 	docs: {
 		description: 'Convert unnamed default exports to named default exports based on the file name.',
 		url: 'https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/no-default-export.md'