minor: fixed some warnings, typos

tmtron · tmtron · commit bace25820d47 · 2018-06-08T12:18:59.000+02:00
diff --git a/.idea/modules/enum-mapper-lib/enum-mapper-lib.iml b/.idea/modules/enum-mapper-lib/enum-mapper-lib.iml
diff --git a/.idea/modules/enum-mapper-lib/enum-mapper-lib_main.iml b/.idea/modules/enum-mapper-lib/enum-mapper-lib_main.iml
diff --git a/.idea/modules/enum-mapper-lib/enum-mapper-lib_test.iml b/.idea/modules/enum-mapper-lib/enum-mapper-lib_test.iml
diff --git a/.idea/modules/enum-mapper-processor/enum-mapper-processor.iml b/.idea/modules/enum-mapper-processor/enum-mapper-processor.iml
diff --git a/.idea/modules/enum-mapper-processor/enum-mapper-processor_main.iml b/.idea/modules/enum-mapper-processor/enum-mapper-processor_main.iml
diff --git a/.idea/modules/enum-mapper-processor/enum-mapper-processor_test.iml b/.idea/modules/enum-mapper-processor/enum-mapper-processor_test.iml
diff --git a/enum-mapper-lib/src/main/java/com/tmtron/enums/EnumMapperPartial.java b/enum-mapper-lib/src/main/java/com/tmtron/enums/EnumMapperPartial.java
@@ -25,7 +25,7 @@
  * <p> In comparison to {@link EnumMapperFull} it will not check if all enumerations constants are mapped.
  * </p>
  * <p>
- * Note: this class does not allow for {@code null} values. You may use {@link java.util.Optional} as type.
+ * Note: this class does not allow for {@code null} values. You may use {@code java.util.Optional} as type.
  * </p>
  *
  * @param <K> the enum-type
diff --git a/enum-mapper-lib/src/test/java/com/tmtron/enums/TestEnumMapperFull.java b/enum-mapper-lib/src/test/java/com/tmtron/enums/TestEnumMapperFull.java
@@ -75,24 +75,24 @@ public void testMapperOfThrowsOnMissingValues8() {
     }
 
     @Test(expected = IllegalArgumentException.class)
-    public void testBuilderThrowsOnMissingValues() throws Exception {
+    public void testBuilderThrowsOnMissingValues() {
         EnumMapperFull<Nine, String> mapper = EnumMapperFull.builder(I1, "1")
                 .put(I2, "2")
                 .build();
     }
 
     @Test
-    public void testGetOrDefault() throws Exception {
+    public void testGetOrDefault() {
         assertEquals(I7, fullMapper.getEnumOrDefault(77, I7));
     }
 
     @Test
-    public void testGetOrNull() throws Exception {
+    public void testGetOrNull() {
         assertNull(fullMapper.getEnumOrNull(77));
     }
 
     @Test(expected = IllegalArgumentException.class)
-    public void testGetOrRaise() throws Exception {
+    public void testGetOrRaise() {
         fullMapper.getEnumOrRaise(77);
     }
 
diff --git a/enum-mapper-lib/src/test/java/com/tmtron/enums/TestEnumMapperFullExamples.java b/enum-mapper-lib/src/test/java/com/tmtron/enums/TestEnumMapperFullExamples.java
@@ -22,7 +22,7 @@
 public class TestEnumMapperFullExamples {
 
     @Test
-    public void testBool() throws Exception {
+    public void testBool() {
         EnumMapperFull<TwoEnums_Source.BoolEnum, String> boolMapper = BoolEnum_MapperFull.setOFF("off")
                 .setON("on");
         assertEquals(TwoEnums_Source.BoolEnum.OFF, boolMapper.getEnumOrRaise("off"));
@@ -33,7 +33,7 @@ public void testBool() throws Exception {
     }
 
     @Test
-    public void testColor() throws Exception {
+    public void testColor() {
         EnumMapperFull<TwoEnums_Source.ColorEnum, String> boolMapper = ColorEnum_MapperFull.setRED("red")
                 .setBLUE("blue");
         assertEquals(TwoEnums_Source.ColorEnum.RED, boolMapper.getEnumOrRaise("red"));
diff --git a/enum-mapper-lib/src/test/java/com/tmtron/enums/TestLauncherAge.java b/enum-mapper-lib/src/test/java/com/tmtron/enums/TestLauncherAge.java
@@ -31,14 +31,14 @@ enum LauncherAge {
             .setOFFLINE("offline");
 
     @Test
-    public void testLauncherAgeGetEnum() throws Exception {
+    public void testLauncherAgeGetEnum() {
         assertEquals(LauncherAge.ONLINE, testMapper.getEnumOrRaise("online"));
         assertEquals(LauncherAge.OLD, testMapper.getEnumOrRaise("old"));
         assertEquals(LauncherAge.OFFLINE, testMapper.getEnumOrRaise("offline"));
     }
 
     @Test
-    public void testLauncherAgeGetValues() throws Exception {
+    public void testLauncherAgeGetValues() {
         assertEquals("online", testMapper.getValue(LauncherAge.ONLINE));
         assertEquals("old", testMapper.getValue(LauncherAge.OLD));
         assertEquals("offline", testMapper.getValue(LauncherAge.OFFLINE));
diff --git a/enum-mapper-processor/src/main/java/com/tmtron/enums/processor/MapAllEnumsHandler.java b/enum-mapper-processor/src/main/java/com/tmtron/enums/processor/MapAllEnumsHandler.java
@@ -43,7 +43,6 @@ class MapAllEnumsHandler {
     private static final String ENUMS_ID = "value";
     private final ProcessingEnvironment processingEnvironment;
     private final Set<Element> annotatedElements;
-    ;
 
     /**
      * Will process an element (e.g. a class) which must have the {@link EnumMappers} annotation.
diff --git a/enum-mapper-processor/src/main/java/com/tmtron/enums/processor/MapEnumElement.java b/enum-mapper-processor/src/main/java/com/tmtron/enums/processor/MapEnumElement.java
@@ -44,7 +44,7 @@ class MapEnumElement {
      * Will process a single Enum class of the {@link EnumMappers} annotation.
      *
      * @param processingEnvironment the processing environment
-     * @param annotatedElements     the element/s (e.g. classe) which has/have the {@link EnumMappers} annotation
+     * @param annotatedElements     the element/s (e.g. classes) which has/have the {@link EnumMappers} annotation
      * @param enumsClassTypeElement a single Enum class from the "values" array of the {@link EnumMappers} annotation
      */
     MapEnumElement(ProcessingEnvironment processingEnvironment, Collection<Element> annotatedElements,
diff --git a/enum-mapper-processor/src/main/java/com/tmtron/enums/processor/WriteMapperFull.java b/enum-mapper-processor/src/main/java/com/tmtron/enums/processor/WriteMapperFull.java
@@ -91,7 +91,7 @@ private AnnotationSpec createGeneratedAnnotation(Class<?> annotationProcessorCla
     /**
      * Will add the required interfaces for the build-stages to the mapperFullTypeBuilder.
      * <ul>
-     * <li>we need no interface for the first enum-constant, becuase we create a static method for this</li>
+     * <li>we need no interface for the first enum-constant, because we create a static method for this</li>
      * <li>the last interface will return the fully initialized mapper</li>
      * </ul>
      *
diff --git a/enum-mapper-processor/src/test/java/com/tmtron/enums/processor/TestMapper4Seasons.java b/enum-mapper-processor/src/test/java/com/tmtron/enums/processor/TestMapper4Seasons.java
@@ -22,7 +22,7 @@
  */
 public class TestMapper4Seasons extends AnnotationProcessorTest {
     @Test
-    public void test() throws Exception {
+    public void test() {
         assertAboutEnumsProcessing(getJfoResource("Seasons.java"))
                 .compilesWithoutWarnings()
                 .and()
diff --git a/enum-mapper-processor/src/test/java/com/tmtron/enums/processor/TestMappers4AllAnnotations.java b/enum-mapper-processor/src/test/java/com/tmtron/enums/processor/TestMappers4AllAnnotations.java
@@ -23,7 +23,7 @@
  */
 public class TestMappers4AllAnnotations extends AnnotationProcessorTest {
     @Test
-    public void test() throws Exception {
+    public void test() {
         assertAboutEnumsProcessing(getJfoResource("AllAnnotations_Source.java"))
                 .compilesWithoutWarnings()
                 .and()
diff --git a/enum-mapper-processor/src/test/java/com/tmtron/enums/processor/TestMappers4DuplicateEnums.java b/enum-mapper-processor/src/test/java/com/tmtron/enums/processor/TestMappers4DuplicateEnums.java
@@ -27,7 +27,7 @@ public class TestMappers4DuplicateEnums extends AnnotationProcessorTest {
      * </p>
      */
     @Test
-    public void test() throws Exception {
+    public void test() {
         assertAboutEnumsProcessing(getJfoResource("DuplicateEnums_Source.java"))
                 .compilesWithoutWarnings()
                 .and()
diff --git a/enum-mapper-processor/src/test/java/com/tmtron/enums/processor/TestMappers4SingleEnum.java b/enum-mapper-processor/src/test/java/com/tmtron/enums/processor/TestMappers4SingleEnum.java
@@ -41,7 +41,7 @@ public void testWarningMessage() {
     }
 
     @Test
-    public void testLauncherAgeMappingFull() throws Exception {
+    public void testLauncherAgeMappingFull() {
         assertAboutEnumsProcessing(source)
                 .compilesWithoutWarnings()
                 .and()
diff --git a/enum-mapper-processor/src/test/java/com/tmtron/enums/processor/TestMappers4TwoEnums.java b/enum-mapper-processor/src/test/java/com/tmtron/enums/processor/TestMappers4TwoEnums.java
@@ -19,7 +19,7 @@
 
 public class TestMappers4TwoEnums extends AnnotationProcessorTest {
     @Test
-    public void test() throws Exception {
+    public void test() {
         assertAboutEnumsProcessing(getJfoResource("TwoEnums_Source.java"))
                 .compilesWithoutWarnings()
                 .and()
diff --git a/enum-mapper-processor/src/test/java/com/tmtron/enums/processor/TestMappersOn2Classes.java b/enum-mapper-processor/src/test/java/com/tmtron/enums/processor/TestMappersOn2Classes.java
@@ -19,7 +19,7 @@
 
 public class TestMappersOn2Classes extends AnnotationProcessorTest {
     @Test
-    public void test() throws Exception {
+    public void test() {
         assertAboutEnumsProcessing(getJfoResource("TwoClasses_Source.java"))
                 .compilesWithoutWarnings()
                 .and()

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@`
`25`	`25`	`* <p> In comparison to {@link EnumMapperFull} it will not check if all enumerations constants are mapped.`
`26`	`26`	`* </p>`
`27`	`27`	`* <p>`
`28`		`- * Note: this class does not allow for {@code null} values. You may use {@link java.util.Optional} as type.`
	`28`	`+ * Note: this class does not allow for {@code null} values. You may use {@code java.util.Optional} as type.`
`29`	`29`	`* </p>`
`30`	`30`	`*`
`31`	`31`	`* @param <K> the enum-type`
Original file line number	Diff line number	Diff line change
`@@ -75,24 +75,24 @@ public void testMapperOfThrowsOnMissingValues8() {`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`@Test(expected = IllegalArgumentException.class)`
`78`		`- public void testBuilderThrowsOnMissingValues() throws Exception {`
	`78`	`+ public void testBuilderThrowsOnMissingValues() {`
`79`	`79`	`EnumMapperFull<Nine, String> mapper = EnumMapperFull.builder(I1, "1")`
`80`	`80`	`.put(I2, "2")`
`81`	`81`	`.build();`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`@Test`
`85`		`- public void testGetOrDefault() throws Exception {`
	`85`	`+ public void testGetOrDefault() {`
`86`	`86`	`assertEquals(I7, fullMapper.getEnumOrDefault(77, I7));`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`@Test`
`90`		`- public void testGetOrNull() throws Exception {`
	`90`	`+ public void testGetOrNull() {`
`91`	`91`	`assertNull(fullMapper.getEnumOrNull(77));`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`@Test(expected = IllegalArgumentException.class)`
`95`		`- public void testGetOrRaise() throws Exception {`
	`95`	`+ public void testGetOrRaise() {`
`96`	`96`	`fullMapper.getEnumOrRaise(77);`
`97`	`97`	`}`
`98`	`98`