Skip to content

Commit 247f3c6

Browse files
committed
fix: fixed circular dependency.
1 parent 0ea0d2f commit 247f3c6

File tree

2 files changed

+10
-19
lines changed

2 files changed

+10
-19
lines changed

src/client/SeedOpenStateSwitcher.ts

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,15 @@
1-
import {Model} from './model';
2-
31
class SeedOpenStateSwitcher {
42
private _isOpen = false;
53

64
private _details: NodeListOf<HTMLDetailsElement> | null = null;
75

86
private _textElement: HTMLElement | null;
97

10-
constructor(_button: HTMLButtonElement, model: Model) {
8+
constructor(_button: HTMLButtonElement) {
119
this._textElement = document.getElementById('btn-toggle-visible-state-text');
12-
_button.addEventListener('click', this.onClick.bind(this));
10+
this._details = document.querySelectorAll<HTMLDetailsElement>('.detail');
1311

14-
model.addEventListener(Model.EVENT.DATA_UPDATE, this.onDataUpdated.bind(this));
12+
_button.addEventListener('click', this.onClick.bind(this));
1513
}
1614

1715
private open() {
@@ -47,16 +45,12 @@ class SeedOpenStateSwitcher {
4745
this.close();
4846
}
4947
}
50-
51-
private onDataUpdated() {
52-
this._details = document.querySelectorAll<HTMLDetailsElement>('.detail');
53-
}
5448
}
5549

56-
export const setSeedOpenStateSwitcher = (model: Model): void => {
50+
export const setSeedOpenStateSwitcher = (): void => {
5751
const btn = document.getElementById('btn-toggle-visible-state');
5852

5953
if (btn) {
60-
new SeedOpenStateSwitcher(btn as HTMLButtonElement, model);
54+
new SeedOpenStateSwitcher(btn as HTMLButtonElement);
6155
}
6256
};

src/client/dialog/index.ts

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import {capture} from '../ScreenCapture';
21
import {disableTabIndex, resetTabIndex} from '../common';
32

43
class CustomDialog {
@@ -18,33 +17,31 @@ class CustomDialog {
1817
}
1918
}
2019

21-
show() {
20+
private show() {
2221
document.body.classList.add('-dialog-show');
2322
disableTabIndex('#dialog');
2423
}
2524

26-
close() {
25+
private close() {
2726
document.body.classList.remove('-dialog-show');
2827
resetTabIndex();
2928
}
3029

31-
load() {
30+
public load() {
3231
this.show();
3332

3433
if (this._contents) {
3534
this._contents.innerHTML = '<p>now loading...</p>';
3635
}
3736
}
3837

39-
complete(html: string) {
38+
private complete(html: string) {
4039
if (this._contents) {
4140
this._contents.innerHTML = html;
4241
}
4342
}
4443

45-
async showExportDialog() {
46-
this.load();
47-
const img = await capture();
44+
showExportDialog(img: HTMLImageElement) {
4845
this._btnExport.href = img.src;
4946
this.complete(img.outerHTML);
5047
}

0 commit comments

Comments
 (0)