Downsized unit tests a little

Author: tjohnston-softdev

net-solution/PalindromePartitions.Tests/FullAlgorithmTests.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Collections.Generic;
 using NUnit.Framework;
 using PalindromePartitions.Classes;

net-solution/PalindromePartitions.Tests/InputTests.cs

@@ -11,9 +11,9 @@ namespace PalindromePartitions.Tests
 	public class InputTests
     {
 		// Error message strings.
-		private static string emptyErrorText = "Input string is missing.";
-		private static string maxLengthText = "Input string can only have up to 100 characters.";
-		private static string wrongCharsText = "Input string must only contain alphanumeric characters.";
+		private static readonly string EmptyErrorText = "Input string is missing.";
+		private static readonly string MaxLengthText = "Input string can only have up to 100 characters.";
+		private static readonly string WrongCharsText = "Input string must only contain alphanumeric characters.";
 
         [Test]
         public void ValidString()
@@ -29,36 +29,36 @@ public void ValidString()
 		public void EmptyArguments()
 		{
 			TryCatchResult testOutcome = InvalidCalls.ArgumentValidationEmpty();
-			InvalidCalls.CheckErrorResult(testOutcome, emptyErrorText);
+			InvalidCalls.CheckErrorResult(testOutcome, EmptyErrorText);
 		}
 
 		[Test]
 		public void EmptyString()
 		{
 			TryCatchResult testOutcome = InvalidCalls.ArgumentValidationPopulated("");
-			InvalidCalls.CheckErrorResult(testOutcome, emptyErrorText);
+			InvalidCalls.CheckErrorResult(testOutcome, EmptyErrorText);
 		}
 
 		[Test]
 		public void StringTooLong()
 		{
 			string reallyLongEntry = LongString.Write();
 			TryCatchResult testOutcome = InvalidCalls.ArgumentValidationPopulated(reallyLongEntry);
-			InvalidCalls.CheckErrorResult(testOutcome, maxLengthText);
+			InvalidCalls.CheckErrorResult(testOutcome, MaxLengthText);
 		}
 
 		[Test]
 		public void InvalidCharacters()
 		{
 			TryCatchResult testOutcome = InvalidCalls.ArgumentValidationPopulated("qu!ck-#rwn-f()%");
-			InvalidCalls.CheckErrorResult(testOutcome, wrongCharsText);
+			InvalidCalls.CheckErrorResult(testOutcome, WrongCharsText);
 		}
 
 		[Test]
 		public void InvalidSpaces()
 		{
 			TryCatchResult testOutcome = InvalidCalls.ArgumentValidationPopulated("This string has spaces in it");
-			InvalidCalls.CheckErrorResult(testOutcome, wrongCharsText);
+			InvalidCalls.CheckErrorResult(testOutcome, WrongCharsText);
 		}
     }
 }

net-solution/PalindromePartitions.Tests/PartitionObjectTests.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Collections.Generic;
 using NUnit.Framework;
 using PalindromePartitions.Classes;
@@ -10,41 +9,18 @@ namespace PalindromePartitions.Tests
 	[TestFixture]
 	public class PartitionObjectTests
     {
-		// Object type shortcut.
-		private static readonly Type ObjectType = typeof(Partition);
-		
-		// Error message strings.
+        // Error message strings.
 		private static readonly string NegativeText = "Non-negative number required. (Parameter 'index')";
 		private static readonly string BoundText = WriteBoundErrorText();
 
 
-        // 'Join' function.
-		[Test]
-		public void JoinFunction()
-		{
-			Partition emptyObj = Partition.Empty();
-			string emptyJoin = emptyObj.Join();
-			Assert.AreEqual(emptyJoin, "");
-		}
-		
-		
-		// 'Empty' constructor.
-		[Test]
-        public void EmptyObjectConstructor()
-        {
-			Partition emptyObj = Partition.Empty();
-			Assert.AreEqual(emptyObj.Count, 0);
-        }
-		
-		
-		// 'Initialize' constructor - Valid.
+        // 'Initialize' constructor - Valid.
 		[Test]
 		public void InitializeObjectConstructorValid()
 		{
 			string entryString = "quickbrownfox";
 			Partition intlObj = Partition.Initialize(ref entryString);
-			Assert.IsInstanceOf(ObjectType, intlObj);
-			Assert.AreEqual(intlObj.Count, entryString.Length);
+            Assert.AreEqual(intlObj.Count, entryString.Length);
 			PartitionContents.CompareInitializedConstructor(ref entryString, intlObj);
 		}
 
@@ -86,7 +62,6 @@ public void ParseObjectConstructorValid()
 			string entryString = "meow,tacocat,hiss";
 			Partition parsedObj = Partition.Parse(entryString);
 
-            Assert.IsInstanceOf(ObjectType, parsedObj);
 			Assert.AreEqual(parsedObj.Count, 3);
 			string actualJoin = PartitionContents.Check(parsedObj);
 			Assert.AreEqual(entryString, actualJoin);
@@ -242,7 +217,6 @@ public void DeriveObjectConstructorBegin()
 			Partition originalObject = Partition.Parse("ta,co,cat,abc,def");
 			Partition derivedObject = Partition.Derive(originalObject, "tacocat", 0, 2);
 
-            Assert.IsInstanceOf(ObjectType, derivedObject);
 			string deriveJoin = derivedObject.Join();
 
 			Assert.AreEqual(deriveJoin, "tacocat,abc,def");

net-solution/PalindromePartitions.Tests/ResultOutputTests.cs

@@ -1,7 +1,5 @@
-using System;
 using NUnit.Framework;
 using PalindromePartitions.Tasks;
-using PalindromePartitions.Tests.Common;
 
 namespace PalindromePartitions.Tests
 {
@@ -10,26 +8,9 @@ namespace PalindromePartitions.Tests
 	public class ResultOutputTests
     {
         [Test]
-        public void Complete()
+        public void Placeholder()
         {
-			int testFlag = AlgorithmResults.GetOutputType(20);
-			Assert.Positive(testFlag);
+			Assert.True(true);
         }
-		
-		[Test]
-		public void Truncated()
-		{
-			int testFlag = AlgorithmResults.GetOutputType(500);
-			Assert.Zero(testFlag);
-		}
-		
-		
-		[Test]
-		public void Empty()
-		{
-			int testFlag = AlgorithmResults.GetOutputType(-1);
-			Assert.Negative(testFlag);
-		}
-		
     }
 }

net-solution/PalindromePartitions/Tasks/AlgorithmResults.cs

@@ -36,34 +36,9 @@ public static void OutputPartitions(List<Partition> resList)
 				Console.WriteLine("No partitions found");
 			}
 		}
-		
-		
-		// Debug function indicates output mode based on given number. Used for unit testing.
-		public static int GetOutputType(int resultCount)
-        {
-            int resultFlag;
-			
-			if (resultCount > 0 && resultCount <= MaxResultsDisplay)
-			{
-				// Complete.
-				resultFlag = 1;
-			}
-			else if (resultCount > MaxResultsDisplay)
-			{
-				// Truncated.
-				resultFlag = 0;
-			}
-			else
-			{
-				// Empty.
-				resultFlag = -1;
-			}
-			
-			return resultFlag;
-		}
-		
-		
-		// Output display loop.
+
+
+        // Output display loop.
 		private static void PrintOutput(List<Partition> rList)
 		{
             int loopCutoff = Math.Min(rList.Count, MaxResultsDisplay);