Merge pull request #8 from titsuki/fix-type-problem

Fix a type problem

Author: titsuki

lib/Algorithm/MinMaxHeap.pm6

@@ -7,17 +7,12 @@ use Algorithm::MinMaxHeap::CmpOperator;
 has @.nodes;
 has Mu $.type;
 
-multi submethod BUILD() {
-    $!type = Int;
-}
-
-multi submethod BUILD(Mu:U :$!type) {
-    if (Algorithm::MinMaxHeap::Comparable|Cool|Str|Rat|Int|Num ~~ $!type) {
-	# nothing to do
-    } else {
-	die "ERROR: Not compatible type is specified";
-    }
-}
+multi submethod BUILD(Int:U :$!type) { Int === $!type or die "ERROR: Not compatible type is specified"; } # when no parameters are specified $!type === Int
+multi submethod BUILD(Algorithm::MinMaxHeap::Comparable:U :$!type) { Algorithm::MinMaxHeap::Comparable === $!type or die "ERROR: Not compatible type is specified"; }
+multi submethod BUILD(Str:U :$!type) { Str === $!type or die "ERROR: Not compatible type is specified"; }
+multi submethod BUILD(Rat:U :$!type) { Rat === $!type or die "ERROR: Not compatible type is specified"; }
+multi submethod BUILD(Num:U :$!type) { Num === $!type or die "ERROR: Not compatible type is specified"; }
+multi submethod BUILD(Cool:U :$!type) { Cool === $!type or die "ERROR: Not compatible type is specified"; }
 
 method insert($value) {
     if (not $value.WHAT ~~ $!type) {

t/01-basic.t

@@ -5,11 +5,44 @@ use Algorithm::MinMaxHeap;
 lives-ok { my $heap = Algorithm::MinMaxHeap.new(); }
 lives-ok { my $heap = Algorithm::MinMaxHeap.new(type => Cool); }
 lives-ok { my $heap = Algorithm::MinMaxHeap.new(type => Algorithm::MinMaxHeap::Comparable); }
-
 lives-ok { my $heap = Algorithm::MinMaxHeap.new(type => Str); }
 lives-ok { my $heap = Algorithm::MinMaxHeap.new(type => Rat); }
 lives-ok { my $heap = Algorithm::MinMaxHeap.new(type => Int); }
 lives-ok { my $heap = Algorithm::MinMaxHeap.new(type => Num); }
-dies-ok { my $heap = Algorithm::MinMaxHeap.new(type => Range); }
+dies-ok { my $heap = Algorithm::MinMaxHeap.new(type => Range); }, "It shouldn't set Range";
+dies-ok { my $heap = Algorithm::MinMaxHeap.new(type => Any); }, "It shouldn't set Any";
+dies-ok { my $heap = Algorithm::MinMaxHeap.new(type => Mu); }, "It shouldn't set Mu";
+dies-ok { my $heap = Algorithm::MinMaxHeap.new(type => Numeric); }, "It shouldn't set Numeric";
+dies-ok { my $heap = Algorithm::MinMaxHeap.new(type => Real); }, "It shouldn't set Real";
+
+{
+    my $heap = Algorithm::MinMaxHeap.new();
+    is $heap.type, Int, "It should be Int";
+}
+
+{
+    my $heap = Algorithm::MinMaxHeap.new(type => Cool);
+    is $heap.type, Cool, "It should be Cool";
+}
+
+{
+    my $heap = Algorithm::MinMaxHeap.new(type => Algorithm::MinMaxHeap::Comparable);
+    is $heap.type, Algorithm::MinMaxHeap::Comparable, "It should be Comparable";
+}
+
+{
+    my $heap = Algorithm::MinMaxHeap.new(type => Str);
+    is $heap.type, Str, "It should be Str";
+}
+
+{
+    my $heap = Algorithm::MinMaxHeap.new(type => Rat);
+    is $heap.type, Rat, "It should be Rat";
+}
+
+{
+    my $heap = Algorithm::MinMaxHeap.new(type => Num);
+    is $heap.type, Num, "It should be Num";
+}
 
 done-testing;