Fix resolution bug with empty panels (#6759)

* Fix bug

* add test

* Add news bullet

Author: teunbrand

DESCRIPTION

@@ -70,7 +70,7 @@ Suggests:
     rpart,
     sf (>= 0.7-3),
     svglite (>= 2.1.2),
-    testthat (>= 3.1.5),
+    testthat (>= 3.3.0),
     tibble,
     vdiffr (>= 1.0.6),
     xml2

NEWS.md

@@ -4,6 +4,8 @@
   (@lgaborini, #6724)
 * Added new argument `geom_curve(shape)` that will be passed down to 
   `grid::curveGrob()` (@fmarotta, #5998).
+* Fixed a regression where default `width` was miscalculated when some panels
+  are empty (@teunbrand, #6758)
 
 # ggplot2 4.0.1
 

R/utilities.R

@@ -927,7 +927,7 @@ compute_data_size <- function(data, size, default = 0.9,
   panels <- arg_match0(panels, c("across", "by", "ignore"))
 
   if (panels == "across") {
-    res <- split(data[[var]], data$PANEL, drop = FALSE)
+    res <- split(data[[var]], data$PANEL, drop = TRUE)
     res <- vapply(res, resolution, FUN.VALUE = numeric(1), ...)
     res <- min(res, na.rm = TRUE)
   } else if (panels == "by") {

tests/testthat/test-utilities.R

@@ -197,3 +197,13 @@ test_that("fallback_palette finds palettes", {
   pal <- fallback_palette(sc)
   expect_true(is_discrete_pal(pal))
 })
+
+test_that("compute_data_size handles gnarly cases", {
+  # Test missing levels
+  df <- data_frame0(
+    x = seq(0, 20, by = 2),
+    PANEL = factor(rep("B", 11), levels = c("A", "B"))
+  )
+  new <- compute_data_size(df, size = NULL, target = "width", default = 1)
+  expect_all_equal(new$width, 2)
+})