Skip to content

Conversation

@reubenmiller
Copy link
Contributor

@reubenmiller reubenmiller commented Nov 10, 2025

Proposed changes

Update robotframework-devicelibrary to 1.23.1 which includes an improvement to the Transfer to Device keyword which will now thrown an error if the given source path does not match any files (rather than silently continuing).

The improvement should help developers spot typos / invalid source paths as experienced here.

Below shows an example of the error message which is presented to the user should the Transfer to Device keyword not find any files to transfter.

==============================================================================
Tedge Flows                                                                   
==============================================================================
Add missing timestamps                                                | FAIL |
Parent suite setup failed:
ValueError: No matching files found. Check the source patterns and try again. patterns=['/Users/example/dev/projects/thin-edge.io/code/thin-edge.io/tests/RobotFramework/tests/tedge_flows/flows2/*']

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller requested a review from a team as a code owner November 10, 2025 03:44
@reubenmiller reubenmiller added theme:testing Theme: Testing skip-release-notes Don't include the ticket in the auto generated release notes labels Nov 10, 2025
@reubenmiller reubenmiller mentioned this pull request Nov 10, 2025
13 tasks
@github-actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
742 0 3 742 100 2h33m7.371231s

@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@reubenmiller reubenmiller added this pull request to the merge queue Nov 10, 2025
Merged via the queue into thin-edge:main with commit bafbd05 Nov 10, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Don't include the ticket in the auto generated release notes theme:testing Theme: Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants