Skip to content

Commit de415d3

Browse files
authored
Fix possible name colision
If for some reason there is a ACF field with name "title" it will overwrite the original page title. Grouping ACF values into is own object will be easier to find as well as prevent name collision.
1 parent ad6d3bc commit de415d3

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

wp-rest-api-v2-menus.php

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,11 @@ function wp_api_v2_menus_get_all_menus() {
1919
if ( class_exists( 'acf' ) ) {
2020
$fields = get_fields( $menu );
2121
if ( ! empty( $fields ) ) {
22+
$menu[ $key ]->acf = new stdClass();
23+
2224
foreach ( $fields as $field_key => $item ) {
2325
// add all acf custom fields
24-
$menus[ $key ]->$field_key = $item;
26+
$menus[ $key ]->acf->$field_key = $item;
2527
}
2628
}
2729
}
@@ -75,9 +77,11 @@ function wp_api_v2_locations_get_menu_data( $data ) {
7577
if ( class_exists( 'acf' ) ) {
7678
$fields = get_fields( $menu );
7779
if ( ! empty( $fields ) ) {
80+
$menu->acf = new stdClass();
81+
7882
foreach ( $fields as $field_key => $item ) {
7983
// add all acf custom fields
80-
$menu->$field_key = $item;
84+
$menu->acf->$field_key = $item;
8185
}
8286
}
8387
}
@@ -142,9 +146,11 @@ function wp_api_v2_menus_get_menu_items( $id ) {
142146
foreach ( $menu_items as $menu_key => $menu_item ) {
143147
$fields = get_fields( $menu_item->ID );
144148
if ( ! empty( $fields ) ) {
149+
$menu_items[$menu_key]->acf = new stdClass();
150+
145151
foreach ( $fields as $field_key => $item ) {
146152
// add all acf custom fields
147-
$menu_items[ $menu_key ]->$field_key = $item;
153+
$menu_items[ $menu_key ]->acf->$field_key = $item;
148154
}
149155
}
150156
}
@@ -232,9 +238,11 @@ function wp_api_v2_menus_get_menu_data( $data ) {
232238
if ( class_exists( 'acf' ) ) {
233239
$fields = get_fields( $menu );
234240
if ( ! empty( $fields ) ) {
241+
$menu->acf = new stdClass();
242+
235243
foreach ( $fields as $field_key => $item ) {
236244
// add all acf custom fields
237-
$menu->$field_key = $item;
245+
$menu->acf->$field_key = $item;
238246
}
239247
}
240248
}

0 commit comments

Comments
 (0)