Merge pull request #42 from thebatclaudio/41-array_values-throwing-a-typeerror

thebatclaudio · web-flow · commit ab34f4ea1d7f · 2022-10-12T16:50:04.000+02:00
fix array_values() throwing a TypeError
diff --git a/wp-rest-api-v2-menus.php b/wp-rest-api-v2-menus.php
@@ -28,7 +28,7 @@ function wp_api_v2_menus_get_all_menus() {
 			}
 		}
 	}
-	
+
 	return apply_filters('wp_api_v2_menus__menus', $menus);
 }
 
@@ -139,6 +139,12 @@ function wp_api_v2_find_object_by_id( $array, $id ) {
  */
 function wp_api_v2_menus_get_menu_items( $id ) {
 	$menu_items = wp_get_nav_menu_items( $id );
+
+    // fallback: if menu_items is null then return empty array
+    if($menu_items === false) {
+        return [];
+    }
+
 	$all_menu_items = $menu_items;
 
 	// check if there is acf installed

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ function wp_api_v2_menus_get_all_menus() {`
`28`	`28`	`}`
`29`	`29`	`}`
`30`	`30`	`}`
`31`		`-`
	`31`	`+`
`32`	`32`	`return apply_filters('wp_api_v2_menus__menus', $menus);`
`33`	`33`	`}`
`34`	`34`
`@@ -139,6 +139,12 @@ function wp_api_v2_find_object_by_id( $array, $id ) {`
`139`	`139`	`*/`
`140`	`140`	`function wp_api_v2_menus_get_menu_items( $id ) {`
`141`	`141`	`$menu_items = wp_get_nav_menu_items( $id );`
	`142`	`+`
	`143`	`+ // fallback: if menu_items is null then return empty array`
	`144`	`+ if($menu_items === false) {`
	`145`	`+ return [];`
	`146`	`+ }`
	`147`	`+`
`142`	`148`	`$all_menu_items = $menu_items;`
`143`	`149`
`144`	`150`	`// check if there is acf installed`